incubator-adffaces-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam Winer (JIRA)" <adffaces-iss...@incubator.apache.org>
Subject [jira] Closed: (ADFFACES-1) tableSelectMany may break with non-string row keys
Date Mon, 08 May 2006 17:41:21 GMT
     [ http://issues.apache.org/jira/browse/ADFFACES-1?page=all ]
     
Adam Winer closed ADFFACES-1:
-----------------------------

    Resolution: Fixed

Fixed in SVN drop.

> tableSelectMany may break with non-string row keys
> --------------------------------------------------
>
>          Key: ADFFACES-1
>          URL: http://issues.apache.org/jira/browse/ADFFACES-1
>      Project: MyFaces ADF-Faces
>         Type: Bug

>  Environment: all
>     Reporter: Frank Felix Debatin
>     Assignee: Adam Winer

>
> from RowKeySet.java: the cast to String is unnecessary and wrong. (This would break if
you clicked "Select All", then deselected a row, and had a non-string row key).
>  private Object _next()
>       {
>         while(rowKeyIterator.hasNext())
>         {
>           String rowKey = (String) rowKeyIterator.next(); // !? 
>           if (!set.contains(rowKey))
>             return rowKey;
>         }
>         return null;
>       }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message