From adffaces-dev-return-2389-apmail-incubator-adffaces-dev-archive=incubator.apache.org@incubator.apache.org Wed Apr 04 22:46:13 2007 Return-Path: Delivered-To: apmail-incubator-adffaces-dev-archive@locus.apache.org Received: (qmail 24563 invoked from network); 4 Apr 2007 22:46:13 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 4 Apr 2007 22:46:13 -0000 Received: (qmail 69334 invoked by uid 500); 4 Apr 2007 22:46:20 -0000 Delivered-To: apmail-incubator-adffaces-dev-archive@incubator.apache.org Received: (qmail 69186 invoked by uid 500); 4 Apr 2007 22:46:20 -0000 Mailing-List: contact adffaces-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: adffaces-dev@incubator.apache.org Delivered-To: mailing list adffaces-dev@incubator.apache.org Received: (qmail 69177 invoked by uid 99); 4 Apr 2007 22:46:20 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Apr 2007 15:46:20 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of awiner@gmail.com designates 64.233.162.229 as permitted sender) Received: from [64.233.162.229] (HELO nz-out-0506.google.com) (64.233.162.229) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Apr 2007 15:46:11 -0700 Received: by nz-out-0506.google.com with SMTP id j2so194481nzf for ; Wed, 04 Apr 2007 15:45:50 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=pEB8oFh9f65T2ZKk+A0JW0L67KUupOkJuzt2EqkNnxr7lFcM2xnoXJPy3EOvOxxyytbVQPaWhlXFLAMglQrPoWA4NM47f9UqoMndO4pY4uz/e5lo6Ch7an8Flxj5vp8j2o+pZDSXGwphdQSpUTZQSVgz9XixgiW0UPiMjUQCw3U= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=cWE3xM7UTln/4xltN/WL8H7UTT0lqy7aMC10g20+choduDn0NM8qsCLJEW3nccryCaGpVr8FqkSsz2altcO2vAqGUwopJkvoGHJ26ceWp1b7yjip6c9eALj5XYIeOInBpbTKSs8SqaU0VR6N8KnMTkigwmpYSYrll5cp7vffzGk= Received: by 10.114.182.1 with SMTP id e1mr471015waf.1175726750410; Wed, 04 Apr 2007 15:45:50 -0700 (PDT) Received: by 10.115.76.3 with HTTP; Wed, 4 Apr 2007 15:45:50 -0700 (PDT) Message-ID: <6dac79b90704041545k5405e34cq3285fd39874bd5ef@mail.gmail.com> Date: Wed, 4 Apr 2007 15:45:50 -0700 From: "Adam Winer" To: adffaces-dev@incubator.apache.org Subject: Re: Problem with showOneAccordion In-Reply-To: <5a99335f0703282144v289f1948kd261c61cd4ffe80e@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <5a99335f0703281514y4c1b5ad0r9974bbe9056155b0@mail.gmail.com> <5a99335f0703282144v289f1948kd261c61cd4ffe80e@mail.gmail.com> X-Virus-Checked: Checked by ClamAV on apache.org panelAccordion is rather badly broken, last I checked. See http://issues.apache.org/jira/browse/ADFFACES-398 And the renderer code for panelAccordion, panelRadio, panelChoice... . Roughly speaking, everything in org.apache.myfaces.trinidadinternal.renderkit.html.layout needs to be rewritten. -- Adam On 3/28/07, Martin Marinschek wrote: > Hi again, > > I've looked at the combined code for CorePanelAccordion and > UIXShowDetail and their renderers and I wonder why the code for doing > the disclosure/closure is spreaded out so much. Wouldn't it be better > to handle this in the detail and the parent components, and in the > renderer only do the rendering of the component? That should be > possible with the event system, right? > > > regards, > > Martin > > > > On 3/29/07, Martin Marinschek wrote: > > Hi *, > > > > can anyone of the Trinidad core developers do me a favour and look at: > > > > http://example.irian.at/trinidad-demo-20070328/faces/components/showOneAccordion.jspx > > > > do you think the behaviour is what a user expects? I would not think > > so... When I click on Panel 1 and then on Panel 2, I would suspect > > Panel 2 to be opened afterwards, but it isn't. > > > > I've added the following code to CorePanelAccordion to make this work again: > > > > @Override > > public void queueEvent(FacesEvent event) { > > super.queueEvent(event); > > > > // Deliver to the default ChartDrillDownEvent > > if (event instanceof DisclosureEvent) > > { > > List li = this.getChildren(); > > > > for(int i=0; i > UIComponent comp = (UIComponent) li.get(i); > > if(comp instanceof UIXShowDetail) { > > ((UIXShowDetail) comp).setDisclosed(false); > > } > > } > > } > > } > > > > but - this code will need to be restricted to take events only of > > direct children, and only for showOneAccordions. Apart from this - > > would you think this is the right approach for a fix? > > > > regards, > > > > Martin > > > > -- > > > > http://www.irian.at > > > > Your JSF powerhouse - > > JSF Consulting, Development and > > Courses in English and German > > > > Professional Support for Apache MyFaces > > > > > -- > > http://www.irian.at > > Your JSF powerhouse - > JSF Consulting, Development and > Courses in English and German > > Professional Support for Apache MyFaces >