incubator-adffaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Robinson <mark.robin...@mizar.com>
Subject Re: PATCH: ServerSide buttons are back
Date Wed, 06 Dec 2006 23:40:55 GMT
So I've cleaned up my patch.

I've removed the dependence on trinidadinternal.ui and I've added some 
classes which I needed to implement server side buttons.

Mark

Adam Winer wrote:
> On 12/5/06, Mark Robinson <mark.robinson@mizar.com> wrote:
>> Adam,
>>
>> By myfaces.ui, do you mean trinidadinternal.ui?
>
> Oops, yes.
>> Is there a reason for
>> getting rid of it?  Also, is there migration documentation?  Ie, class X
>> is gone, use class Y and Z.
>
> It is ancient legacy code - based on UIX - that has to be
> heavily adapted and twisted to work in a JSF environment.
> It's slow, arcane, filled with obsolete code paths, etc., etc.
> Getting rid of it is a major goal in Trinidad.
>
> -- Adam
>
>> Adam Winer wrote:
>> > Mark,
>> >
>> > It's not OK for anything in myfaces.trinidadinternal.renderkit to have
>> > dependencies on code in myfaces.ui;  our goal is to kill all
>> > code in myfaces.ui.
>> >
>> > So, for example:
>> >
>> > import org.apache.myfaces.trinidadinternal.ui.UIXRenderingContext;
>> > import
>> > 
>> org.apache.myfaces.trinidadinternal.ui.laf.simple.desktop.IconInputStreamProvider

>>
>> >
>> > ;
>> > import
>> > 
>> org.apache.myfaces.trinidadinternal.ui.laf.simple.desktop.SimpleDesktopConstants

>>
>> >
>> > ;
>> > import 
>> org.apache.myfaces.trinidadinternal.uinode.FacesRenderingContext;
>> >
>> > ... are all off-limits.  (Looking through the patch, it looks as 
>> though
>> > you've
>> > added some other imports unnecessarily.)
>> >
>> > -- Adam
>> >
>> > 
>> ------------------------------------------------------------------------
>> >
>> > No virus found in this incoming message.
>> > Checked by AVG Free Edition.
>> > Version: 7.5.432 / Virus Database: 268.15.9/573 - Release Date: 
>> 05/12/2006 4:07 PM
>> >
>>
>>
>
>
>
>


Mime
View raw message