incubator-adffaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthias Wessendorf" <mat...@apache.org>
Subject Re: RE (ADFFACES-2) add init-param to make "dialog:xxx" prefix configurable
Date Thu, 06 Jul 2006 23:20:12 GMT
much nicer to the users.

I like it

On 7/6/06, Adam Winer <awiner@gmail.com> wrote:
> -1;  instead, we should append a ":" if it isn't already the last character.
>
> -- Adam
>
>
> On 7/6/06, Matthias Wessendorf <matzew@apache.org> wrote:
> >
> > Trust me guy,
> >
> > there are always some thing you never expected :-)
> >
> > (as mentioned in the JIRA, please use a SVN dif in future ;))
> >
> > -Matt
> >
> > On 7/6/06, Pierre-Luc_Archambault@dmr.ca <Pierre-Luc_Archambault@dmr.ca>
> > wrote:
> > > +1 for the IllegalArgumentException
> > >
> > > I never tought about that when writting the patch... being to "used" in
> > > assuming the user whould be aware of what he's doing and so, should be
> > > using the program in the normal way with always valids arguments !
> > >
> > > mwessendorf@gmail.com a écrit sur 2006-07-06 12:55:58 :
> > >
> > > > I am testing this patch now.
> > > >
> > > > One thing that came up was, what todo, when a user not provides a ":"
> > > >
> > > > like
> > > >
> > > > <context-param>
> > > > <param-name>org.apache.myfaces.adf.DIALOG_NAVIGATION_PREFIX
> > </param-name>
> > > >   <param-value>userInputHere</param-value>
> > > > </context-param>
> > > >
> > > > I am +1 on throwing an IllegalArgumentException.
> > > >
> > > > WDYT ?
> > > >
> > > > -Matt
> > > >
> > > >
> > > > --
> > > > Matthias Wessendorf
> > > >
> > > > futher stuff:
> > > > blog: http://jroller.com/page/mwessendorf
> > > > mail: mwessendorf-at-gmail-dot-com
> > >
> > >
> >
> >
> > --
> > Matthias Wessendorf
> >
> > futher stuff:
> > blog: http://jroller.com/page/mwessendorf
> > mail: mwessendorf-at-gmail-dot-com
> >
>
>


-- 
Matthias Wessendorf

futher stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com

Mime
View raw message