incubator-adffaces-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam Winer" <awi...@gmail.com>
Subject Re: svn commit: r495895 - /incubator/adffaces/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/io/XhtmlResponseWriter.java
Date Sat, 13 Jan 2007 17:48:52 GMT
Whoa there!   We can't make this change in JSF 1.1.

In JSF 1.1, flush() has a very specific mixed meaning because
of the interweaving of JSP execution and UIComponent rendering.
flush() means "some ordinary JSP output may be coming,
so flush all buffered ResponseWriter content".

In JSF 1.2, flush() can mean something normal.  So,
I think this change needs to be rolled back from 1.1
and applied to 1.2 only (to all ResponseWriters, not
just XhtmlResponseWriter).

-- Adam


On 1/13/07, matzew@apache.org <matzew@apache.org> wrote:
> Author: matzew
> Date: Sat Jan 13 04:54:54 2007
> New Revision: 495895
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=495895
> Log:
> added _out.flush() => ADFFACES-352
>
> Modified:
>     incubator/adffaces/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/io/XhtmlResponseWriter.java
>
> Modified: incubator/adffaces/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/io/XhtmlResponseWriter.java
> URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/io/XhtmlResponseWriter.java?view=diff&rev=495895&r1=495894&r2=495895
> ==============================================================================
> --- incubator/adffaces/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/io/XhtmlResponseWriter.java
(original)
> +++ incubator/adffaces/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/io/XhtmlResponseWriter.java
Sat Jan 13 04:54:54 2007
> @@ -87,6 +87,7 @@
>    public void flush() throws IOException
>    {
>      _closeStartIfNecessary();
> +    _out.flush();
>    }
>
>
>
>
>

Mime
View raw message