incubator-adffaces-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jwald...@apache.org
Subject svn commit: r500011 - /incubator/adffaces/branches/jwaldman-portal/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/CoreRenderingContext.java
Date Thu, 25 Jan 2007 22:02:09 GMT
Author: jwaldman
Date: Thu Jan 25 14:02:08 2007
New Revision: 500011

URL: http://svn.apache.org/viewvc?view=rev&rev=500011
Log:
ADFFACES-364 PartialPageContext optimization bug. Check in for Scoot O'Bryan to jwaldman-portal
branch.

Remove this optimization in _initializePPR:
    // Don't bother if PPR isn't even supported
    if (!CoreRendererUtils.supportsPartialRendering(this))
      return;

The reason is commented in the code:
    //There used to be an optimization here which would simply return when
    //the PartialRendering capabilities were disabled.  This was removed
    //because it is possible for extensions to Trinidad to support PPR in a 
    //container-specific way in a Portal Environment even though such capability
    //is off by default.  Furthermore, the check on whether something is a
    //PPR request or not is very efficient, so there is very little time saved
    //by the optimization.

Modified:
    incubator/adffaces/branches/jwaldman-portal/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/CoreRenderingContext.java

Modified: incubator/adffaces/branches/jwaldman-portal/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/CoreRenderingContext.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/branches/jwaldman-portal/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/CoreRenderingContext.java?view=diff&rev=500011&r1=500010&r2=500011
==============================================================================
--- incubator/adffaces/branches/jwaldman-portal/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/CoreRenderingContext.java
(original)
+++ incubator/adffaces/branches/jwaldman-portal/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/CoreRenderingContext.java
Thu Jan 25 14:02:08 2007
@@ -466,9 +466,13 @@
     FacesContext    fContext,
     RequestContext context)
   {
-    // Don't bother if PPR isn't even supported
-    if (!CoreRendererUtils.supportsPartialRendering(this))
-      return;
+    //There used to be an optimization here which would simply return when
+    //the PartialRendering capabilities were disabled.  This was removed
+    //because it is possible for extensions to Trinidad to support PPR in a 
+    //container-specific way in a Portal Environment even though such capability
+    //is off by default.  Furthermore, the check on whether something is a
+    //PPR request or not is very efficient, so there is very little time saved
+    //by the optimization.
 
     PartialPageContext partialPageContext =
       PartialPageUtils.createPartialPageContext(fContext,



Mime
View raw message