incubator-adffaces-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From awi...@apache.org
Subject svn commit: r467517 - /incubator/adffaces/branches/faces-1_2/plugins/maven-faces-plugin/src/main/java/org/apache/myfaces/trinidadbuild/plugin/faces/GenerateJspTaglibsMojo.java
Date Tue, 24 Oct 2006 22:57:12 GMT
Author: awiner
Date: Tue Oct 24 15:57:11 2006
New Revision: 467517

URL: http://svn.apache.org/viewvc?view=rev&rev=467517
Log:
Make "binding" have a <deferred-value/> element in the TLD.  At least in Glassfish,
this does not appear to be necessary, but I can't find any in the spec that requires that
attributes on a tag of type ValueExpression default to being deferred-values.

Also, fix up the indenting of deferred-value sections.

Modified:
    incubator/adffaces/branches/faces-1_2/plugins/maven-faces-plugin/src/main/java/org/apache/myfaces/trinidadbuild/plugin/faces/GenerateJspTaglibsMojo.java

Modified: incubator/adffaces/branches/faces-1_2/plugins/maven-faces-plugin/src/main/java/org/apache/myfaces/trinidadbuild/plugin/faces/GenerateJspTaglibsMojo.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/branches/faces-1_2/plugins/maven-faces-plugin/src/main/java/org/apache/myfaces/trinidadbuild/plugin/faces/GenerateJspTaglibsMojo.java?view=diff&rev=467517&r1=467516&r2=467517
==============================================================================
--- incubator/adffaces/branches/faces-1_2/plugins/maven-faces-plugin/src/main/java/org/apache/myfaces/trinidadbuild/plugin/faces/GenerateJspTaglibsMojo.java
(original)
+++ incubator/adffaces/branches/faces-1_2/plugins/maven-faces-plugin/src/main/java/org/apache/myfaces/trinidadbuild/plugin/faces/GenerateJspTaglibsMojo.java
Tue Oct 24 15:57:11 2006
@@ -502,17 +502,19 @@
           }
           stream.writeEndElement();
         }
-        else if (!property.isLiteralOnly())
+        else if (!property.isLiteralOnly() ||
+                 // "binding" is always a deferred-value
+                 "binding".equals(propertyName))
         {
-          stream.writeCharacters("\n    ");
+          stream.writeCharacters("\n      ");
           stream.writeStartElement("deferred-value");
           if (_CAN_COERCE.contains(property.getPropertyClass()))
           {
-            stream.writeCharacters("\n      ");
+            stream.writeCharacters("\n        ");
             stream.writeStartElement("type");
             stream.writeCharacters(property.getPropertyClass());
             stream.writeEndElement();
-            stream.writeCharacters("\n    ");
+            stream.writeCharacters("\n      ");
           }
 
           stream.writeEndElement();



Mime
View raw message