incubator-adffaces-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From awi...@apache.org
Subject svn commit: r408948 - in /incubator/adffaces/trunk/adf-faces/adf-faces-api/src/test/java/org/apache/myfaces/adf/model: RowKeySetImplTest.java RowKeySetTreeImplTest.java
Date Tue, 23 May 2006 15:57:29 GMT
Author: awiner
Date: Tue May 23 08:57:28 2006
New Revision: 408948

URL: http://svn.apache.org/viewvc?rev=408948&view=rev
Log:
ADFFACES-9: Brittleness in RowKeySetImplTest.java and RowKeySetTreeImplTest.java

Modified:
    incubator/adffaces/trunk/adf-faces/adf-faces-api/src/test/java/org/apache/myfaces/adf/model/RowKeySetImplTest.java
    incubator/adffaces/trunk/adf-faces/adf-faces-api/src/test/java/org/apache/myfaces/adf/model/RowKeySetTreeImplTest.java

Modified: incubator/adffaces/trunk/adf-faces/adf-faces-api/src/test/java/org/apache/myfaces/adf/model/RowKeySetImplTest.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/adf-faces/adf-faces-api/src/test/java/org/apache/myfaces/adf/model/RowKeySetImplTest.java?rev=408948&r1=408947&r2=408948&view=diff
==============================================================================
--- incubator/adffaces/trunk/adf-faces/adf-faces-api/src/test/java/org/apache/myfaces/adf/model/RowKeySetImplTest.java
(original)
+++ incubator/adffaces/trunk/adf-faces/adf-faces-api/src/test/java/org/apache/myfaces/adf/model/RowKeySetImplTest.java
Tue May 23 08:57:28 2006
@@ -308,8 +308,8 @@
 
       bytes = bos.toByteArray();
       // test to make sure that the serialized size is reasonable:
-      // FIXME: this test is brittle -- it fails if the full classname changes in length
-      assertEquals("serialized size", 91, bytes.length);
+     assertTrue(bytes.length <= 100);
+     assertTrue(bytes.length >= 80);
     }
 
     ObjectInputStream in =

Modified: incubator/adffaces/trunk/adf-faces/adf-faces-api/src/test/java/org/apache/myfaces/adf/model/RowKeySetTreeImplTest.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/adf-faces/adf-faces-api/src/test/java/org/apache/myfaces/adf/model/RowKeySetTreeImplTest.java?rev=408948&r1=408947&r2=408948&view=diff
==============================================================================
--- incubator/adffaces/trunk/adf-faces/adf-faces-api/src/test/java/org/apache/myfaces/adf/model/RowKeySetTreeImplTest.java
(original)
+++ incubator/adffaces/trunk/adf-faces/adf-faces-api/src/test/java/org/apache/myfaces/adf/model/RowKeySetTreeImplTest.java
Tue May 23 08:57:28 2006
@@ -260,10 +260,10 @@
     }
 
     // we're doing a test here to warn the developer if the
-    // serialized size changes. If the size changes are expected, then
-    // change the expected size for this test:
-    // FIXME: this test is brittle -- it fails if the full classname changes in length
-    assertEquals("serialized size", 626, bytes.length);
+    // serialized size changes significantly. If the size changes are
+    // expected, then change the expected range for these tests:
+    assertTrue(bytes.length < 635);
+    assertTrue(bytes.length > 615);
 
     ObjectInputStream in =
       new ObjectInputStream(new ByteArrayInputStream(bytes));



Mime
View raw message