incubator-ace-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pa...@apache.org
Subject svn commit: r1133024 - /incubator/ace/trunk/ace-webui-vaadin/src/main/java/org/apache/ace/webui/vaadin/EditWindow.java
Date Tue, 07 Jun 2011 14:17:21 GMT
Author: pauls
Date: Tue Jun  7 14:17:20 2011
New Revision: 1133024

URL: http://svn.apache.org/viewvc?rev=1133024&view=rev
Log:
Make sure ui extensions don't break the edit window when they throw an exception (ACE-141)

Modified:
    incubator/ace/trunk/ace-webui-vaadin/src/main/java/org/apache/ace/webui/vaadin/EditWindow.java

Modified: incubator/ace/trunk/ace-webui-vaadin/src/main/java/org/apache/ace/webui/vaadin/EditWindow.java
URL: http://svn.apache.org/viewvc/incubator/ace/trunk/ace-webui-vaadin/src/main/java/org/apache/ace/webui/vaadin/EditWindow.java?rev=1133024&r1=1133023&r2=1133024&view=diff
==============================================================================
--- incubator/ace/trunk/ace-webui-vaadin/src/main/java/org/apache/ace/webui/vaadin/EditWindow.java
(original)
+++ incubator/ace/trunk/ace-webui-vaadin/src/main/java/org/apache/ace/webui/vaadin/EditWindow.java
Tue Jun  7 14:17:20 2011
@@ -54,8 +54,14 @@ public class EditWindow extends Window {
         Map<String, Object> context = new HashMap<String, Object>();
         context.put("object", object);
         for (UIExtensionFactory factory : factories) {
-            com.vaadin.ui.Component component = factory.create(context);
-            tabs.addTab(component);
+            try {
+                com.vaadin.ui.Component component = factory.create(context);
+                tabs.addTab(component);
+            } catch (Throwable ex) {
+                // We ignore extension factories that throw exceptions
+                // TODO: log this or something
+                ex.printStackTrace();
+            }
         }
         layout.addComponent(tabs);
 



Mime
View raw message