From user-return-641-archive-asf-public=cust-asf.ponee.io@impala.apache.org Mon Feb 12 17:53:20 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id D8A49180652 for ; Mon, 12 Feb 2018 17:53:20 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id C8F30160C3F; Mon, 12 Feb 2018 16:53:20 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1AE7D160C31 for ; Mon, 12 Feb 2018 17:53:19 +0100 (CET) Received: (qmail 10844 invoked by uid 500); 12 Feb 2018 16:53:19 -0000 Mailing-List: contact user-help@impala.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: user@impala.apache.org Delivered-To: mailing list user@impala.apache.org Received: (qmail 10834 invoked by uid 99); 12 Feb 2018 16:53:19 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Feb 2018 16:53:19 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id B12051801AA for ; Mon, 12 Feb 2018 16:53:18 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.121 X-Spam-Level: X-Spam-Status: No, score=-0.121 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=cloudera.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id laN6M0kTRjuo for ; Mon, 12 Feb 2018 16:53:17 +0000 (UTC) Received: from mail-lf0-f46.google.com (mail-lf0-f46.google.com [209.85.215.46]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 718065F398 for ; Mon, 12 Feb 2018 16:53:17 +0000 (UTC) Received: by mail-lf0-f46.google.com with SMTP id 37so2455827lfs.7 for ; Mon, 12 Feb 2018 08:53:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudera.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=kPVv6nEHRY9ideq+0NOHJFHILpJGKK4804EAUrptEOo=; b=WiE4cHp16DyvZtm/k97w0uc5p+HTTdajU9nKl3AMVwwVoX5VeYKx9okMhyKI1jadrm R+urqlGFVnSEjmTG/3kTZN5mgJtB36ebEb5Gm2q0ea5umsWvNX1FzE34TnsUypeZ7RTM bnKoxNkrFvbMmOnP/FOKhuFDfqPXWWLHwi5tCiZQInvhxZ2W4BLcpmAPWQ7LRf/aEut1 qZU1IM/nP0gA9pQD4M3LNoNvuBkko0tX3EK1L0kOX4yyngrJgzZLpbST9RKTq8becLGi 7eR+tjKIh01oXu2H6gTGuzXar8hZOAjh0Dgoh1n+vsxAj4FwMbs6bIlImLpfexE/2MpQ YYyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=kPVv6nEHRY9ideq+0NOHJFHILpJGKK4804EAUrptEOo=; b=aSflTNrwFAiwQoJIlO6MQTUEBrOI0px1FCPHgmw1MLvkVUedvJlHuv0Cy44pNOoI1H i8zpfc5skIhJySGie3gslV4nrqROuXQCx03C+NWlZba0WDt7Cv55eaBn1ZwnfvUjp4o5 9uJWvMXk18/IBnH8TsYCzaGbFobklgodVUG9AlpDqI8mR9SUdrLYcuw2pXmOfqeRmQWe EJRPNCFq8K9SSt1aEexq4fuAsW5JlnsfoJHVNvN1YSYPJtIpVj2mwJMNSVIK+OYPMZfy PPkiy/mJgBcNVvTDiLlKLZ5Z9nTpG8fFldxY6gTEKKvlZW7uQl954RAIL4KoW7hDBs8n mGiw== X-Gm-Message-State: APf1xPCAYX+CCIYXP7Teqi5He0Mmxrr/JULsTEKAYtRkdpPuzAzFn1IB oP6BiVWMDP7E8gXl8lDTIl3wDxow4K2iMI3clz1xH/h5 X-Google-Smtp-Source: AH8x226njYTQp5Wv6zA4rtPqcw9WYu/dQre8r+/4U4RKIad9LGBXZ+GsDjbuozj1D5IoWSFQg3odmhEgoUmVt5wKqHw= X-Received: by 10.25.178.207 with SMTP id t76mr8216350lfk.111.1518454395895; Mon, 12 Feb 2018 08:53:15 -0800 (PST) MIME-Version: 1.0 Received: by 10.25.203.202 with HTTP; Mon, 12 Feb 2018 08:52:35 -0800 (PST) In-Reply-To: References: From: Jim Apple Date: Mon, 12 Feb 2018 08:52:35 -0800 Message-ID: Subject: Re: Removing "external data source" To: user@impala.apache.org Cc: Marcel Kornacker Content-Type: text/plain; charset="UTF-8" On Wed, Feb 7, 2018 at 11:38 AM, Daniel Hecht wrote: > On Wed, Feb 7, 2018 at 9:18 AM, Marcel Kornacker wrote: >> >> What is gained by removing the code? >> > > The motivation was that we should always be looking for opportunities to > remove code, since we can't just keep adding or else the complexity of > Impala will get out of control over the long term. This was an opportunity > to remove ~5k lines, which is a nice benefit if the feature wasn't being > used. I agree that "we can't just keep adding or else the complexity of Impala will get out of control over the long term." Thanks for bringing up that benefit, Dan. MJ suggested: "An alternative approach to removing this code might be: review the original design/API, create more specific improvement tasks (smaller items may good for aspiring contributors), and document it. Seeing as I have some context on this work, I'd be happy to help with this." One option would be for us to see how that effort progresses in the 3.x line. If it falters, we could re-evaluate at 4.x branching time. If we decide to remove it, I would suggest we deprecate it then, in 4.x, and remove it in 5.0.