From reviews-return-81504-archive-asf-public=cust-asf.ponee.io@impala.apache.org Fri Jul 10 04:33:19 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9DE33180607 for ; Fri, 10 Jul 2020 06:33:19 +0200 (CEST) Received: (qmail 32118 invoked by uid 500); 10 Jul 2020 04:33:18 -0000 Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.apache.org Received: (qmail 32098 invoked by uid 99); 10 Jul 2020 04:33:17 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Jul 2020 04:33:17 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id ABADF18143D for ; Fri, 10 Jul 2020 04:33:16 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.574 X-Spam-Level: X-Spam-Status: No, score=0.574 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, RDNS_DYNAMIC=0.363, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id SwSDTT9MHZbf for ; Fri, 10 Jul 2020 04:33:15 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=75.101.130.251; helo=ip-10-146-233-104.ec2.internal; envelope-from=gerrit@cloudera.org; receiver= Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTPS id 9604D7F68A for ; Fri, 10 Jul 2020 04:33:14 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id 06A4XCAZ018048; Fri, 10 Jul 2020 04:33:12 GMT Message-Id: <202007100433.06A4XCAZ018048@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 10 Date: Fri, 10 Jul 2020 04:33:12 +0000 From: "Tim Armstrong (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Shant Hovsepian , Impala Public Jenkins , David Rorke , Aman Sinha , Zoltan Borok-Nagy X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-9924=3A_handle_single_subquery_in_or_predicate=0A?= X-Gerrit-Change-Id: I64588992901afd7cd885419a0b7f949b0b174976 X-Gerrit-Change-Number: 16152 X-Gerrit-ChangeURL: X-Gerrit-Commit: 5d193203d7233f6347d801f457687cefbca0e3f1 In-Reply-To: References: X-Gerrit-Comment-Date: Fri, 10 Jul 2020 04:33:12 +0000 Reply-To: tarmstrong@cloudera.com, impala-cr@cloudera.com, drorke@cloudera.com, boroknagyz@cloudera.com, marcelk@gmail.com, shant@cloudera.com, amsinha@cloudera.com, impala-public-jenkins@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.15 Content-Type: multipart/alternative; boundary="qCAXX8eFs18="; charset=UTF-8 --qCAXX8eFs18= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Tim Armstrong has posted comments on this change=2E ( http://gerrit=2Ecloud= era=2Eorg:8080/16152 ) Change subject: IMPALA-9924: handle single subquery= in or predicate =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E Patch Set 10: (1 comment) http://gerrit=2Ecloudera=2Eorg:8080/#/c/1= 6152/10/fe/src/main/java/org/apache/impala/analysis/StmtRewriter=2Ejava Fil= e fe/src/main/java/org/apache/impala/analysis/StmtRewriter=2Ejava: http://= gerrit=2Ecloudera=2Eorg:8080/#/c/16152/10/fe/src/main/java/org/apache/impal= a/analysis/StmtRewriter=2Ejava@127 PS10, Line 127: private static boole= an hasSubqueryInDisjunction(Expr expr) { This is now dead code, I can remov= e it=2E -- To view, visit http://gerrit=2Ecloudera=2Eorg:8080/16152 To = unsubscribe, visit http://gerrit=2Ecloudera=2Eorg:8080/settings Gerrit-Pro= ject: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-C= hange-Id: I64588992901afd7cd885419a0b7f949b0b174976 Gerrit-Change-Number: 1= 6152 Gerrit-PatchSet: 10 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Aman Sinha Gerrit-Reviewe= r: David Rorke Gerrit-Reviewer: Impala Public Jenki= ns Gerrit-Reviewer: Shant Hovsepian = Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerr= it-Comment-Date: Fri, 10 Jul 2020 04:33:12 +0000 Gerrit-HasComments: Yes --qCAXX8eFs18=--