impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wenzhe Zhou (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5746: Cancel all queries scheduled by failed coordinators
Date Wed, 29 Jul 2020 17:34:23 GMT
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/16215 )

Change subject: IMPALA-5746: Cancel all queries scheduled by failed coordinators
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/16215/5/be/src/runtime/query-exec-mgr.h
File be/src/runtime/query-exec-mgr.h:

http://gerrit.cloudera.org:8080/#/c/16215/5/be/src/runtime/query-exec-mgr.h@37
PS5, Line 37: absence
> nit: absent
fixed it.


http://gerrit.cloudera.org:8080/#/c/16215/5/be/src/runtime/query-exec-mgr.cc
File be/src/runtime/query-exec-mgr.cc:

http://gerrit.cloudera.org:8080/#/c/16215/5/be/src/runtime/query-exec-mgr.cc@61
PS5, Line 61:   // queue up to the maximum limit and ignore the rest.
> Could you also add: 'The ignored queries will get cancelled when they time 
fixed it



-- 
To view, visit http://gerrit.cloudera.org:8080/16215
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I918fcc27649d5d2bbe8b6ef47fbd9810ae5f57bd
Gerrit-Change-Number: 16215
Gerrit-PatchSet: 5
Gerrit-Owner: Wenzhe Zhou <wzhou@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <stakiar@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wzhou@cloudera.com>
Gerrit-Comment-Date: Wed, 29 Jul 2020 17:34:23 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message