impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-9645 Port LLVM codegen to adapt aarch64
Date Mon, 20 Jul 2020 03:47:01 GMT
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15718
)

Change subject: IMPALA-9645 Port LLVM codegen to adapt aarch64
......................................................................


Patch Set 16:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15718/16/be/src/exprs/scalar-fn-call.cc
File be/src/exprs/scalar-fn-call.cc:

http://gerrit.cloudera.org:8080/#/c/15718/16/be/src/exprs/scalar-fn-call.cc@393
PS16, Line 393:         (col_type == TYPE_BOOLEAN or col_type == TYPE_TINYINT or col_type
== TYPE_SMALLINT)) {
line too long (94 > 90)



-- 
To view, visit http://gerrit.cloudera.org:8080/15718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f30ee84ea9bf5245da88154632bb69079103d11
Gerrit-Change-Number: 15718
Gerrit-PatchSet: 16
Gerrit-Owner: Anonymous Coward <zhaorenhai@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zhaorenhai@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tmate@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Comment-Date: Mon, 20 Jul 2020 03:47:01 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message