impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5226: handle single subquery in or predicate
Date Thu, 09 Jul 2020 23:13:17 GMT
Tim Armstrong has posted comments on this change. ( )

Change subject: IMPALA-5226: handle single subquery in or predicate

Patch Set 8:

Commit Message:
PS8, Line 15: reference to one of the select list expressions of
> nit: to be precise, this is a single select list expression, not 'one of..'
File testdata/workloads/functional-planner/queries/PlannerTest/subquery-rewrite.test:
PS8, Line 3512: |  other predicates: id IS NOT NULL OR t.bool_col = FALSE
> It would be good to have one query (any one of the existing queries) with a
Done. Added to one of the queries below.
PS8, Line 3730: |  other predicates: int_col % 2 = 0 OR <= min(id)
> The right side of the disjunct would have been evaluated during the 'other 
Oh I see what you're saying - we only actually need to check if min(id) is not null. I was
thinking about this the wrong way - in the context where I implemented it, we were already
going to convert the parent of the subquery into a join predicate, so checking IS NOT NULL
works in general, not just for exists.

Thanks for pointing this out, it added some clarity.

So I can remove some code and generate a more efficient expr.

To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I64588992901afd7cd885419a0b7f949b0b174976
Gerrit-Change-Number: 16152
Gerrit-PatchSet: 8
Gerrit-Owner: Tim Armstrong <>
Gerrit-Reviewer: Aman Sinha <>
Gerrit-Reviewer: David Rorke <>
Gerrit-Reviewer: Impala Public Jenkins <>
Gerrit-Reviewer: Shant Hovsepian <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-Reviewer: Zoltan Borok-Nagy <>
Gerrit-Comment-Date: Thu, 09 Jul 2020 23:13:17 +0000
Gerrit-HasComments: Yes

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message