impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sahil Takiar (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-9834: De-flake TestQueryRetries on EC builds
Date Thu, 09 Jul 2020 03:12:54 GMT
Hello Thomas Tauber-Marshall, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16149

to look at the new patch set (#2).

Change subject: IMPALA-9834: De-flake TestQueryRetries on EC builds
......................................................................

IMPALA-9834: De-flake TestQueryRetries on EC builds

This patch skips all tests in TestQueryRetries on EC builds.

The tests in TestQueryRetries runs queries that run on three instances
during regular builds (HDFS, S3, etc.), but only two instances on EC
builds. This causes some non-deterministism during the test because
killing an impalad in the mini-cluster won't necessarily cause a retry
to be triggered.

It bumps up the timeout used when waiting for a query to be retried.

It improves the assertion in __get_query_id_from_profile so that it
dumps the full profile when the assertion fails. This should help
debuggability of any test failures that fail in this assertion.

Testing:
* Ran TestQueryRetries locally

Change-Id: Id5c73c2cbd0ef369175856c41f36d4b0de4b8d71
---
M tests/custom_cluster/test_query_retries.py
1 file changed, 16 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/49/16149/2
-- 
To view, visit http://gerrit.cloudera.org:8080/16149
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id5c73c2cbd0ef369175856c41f36d4b0de4b8d71
Gerrit-Change-Number: 16149
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <stakiar@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message