impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-9834: De-flake TestQueryRetries on EC builds
Date Wed, 08 Jul 2020 17:27:16 GMT
Thomas Tauber-Marshall has posted comments on this change. (

Change subject: IMPALA-9834: De-flake TestQueryRetries on EC builds

Patch Set 1:

Commit Message:
PS1, Line 10: EC builds
Are there any other build types where this might be a concern like S3, eg. should we maybe
use SkipIfNotHdfsMinicluster.tuned_for_minicluster, or is it okay because its a custom_cluster
test so it sort of has to always be run against the minicluster?
File tests/custom_cluster/
PS1, Line 77: self.__kill_random_impalad()
Do we not have the same problem here of the query possibly running on only two nodes in EC?
PS1, Line 226: killed_impalad = self.__kill_random_impalad()
Same here
PS1, Line 561:   def __validate_runtime_profiles(self, retried_runtime_profile, original_query_id,
Might be nice to add some asserts that the profiles show the query getting run on the expected
number of backends.

To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5c73c2cbd0ef369175856c41f36d4b0de4b8d71
Gerrit-Change-Number: 16149
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <>
Gerrit-Reviewer: Impala Public Jenkins <>
Gerrit-Reviewer: Thomas Tauber-Marshall <>
Gerrit-Comment-Date: Wed, 08 Jul 2020 17:27:16 +0000
Gerrit-HasComments: Yes

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message