impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shant Hovsepian (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-8954: Uncorrelated scalar subqueries in the select list
Date Sat, 04 Jul 2020 19:33:29 GMT
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16007
)

Change subject: IMPALA-8954: Uncorrelated scalar subqueries in the select list
......................................................................


Patch Set 8:

(11 comments)

Addressed some comments.

http://gerrit.cloudera.org:8080/#/c/16007/3/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java
File fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java:

http://gerrit.cloudera.org:8080/#/c/16007/3/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java@1113
PS3, Line 1113: 
> nit: implemented
Done


http://gerrit.cloudera.org:8080/#/c/16007/3/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java@1117
PS3, Line 1117:      *
> Is this comment applicable for this patch ? Looks like this patch is suppor
Done


http://gerrit.cloudera.org:8080/#/c/16007/3/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java@1135
PS3, Line 1135:      *
> nit: spelling 'gaurantee'
Done


http://gerrit.cloudera.org:8080/#/c/16007/3/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java@1230
PS3, Line 1230:           // rewrite to a LOJ.
> If the outer query has 2 tables joined in the FROM clause, then we add this
Done


http://gerrit.cloudera.org:8080/#/c/16007/5/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java
File fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java:

http://gerrit.cloudera.org:8080/#/c/16007/5/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java@1114
PS5, Line 1114: implemeted
> nit: implemented
Done


http://gerrit.cloudera.org:8080/#/c/16007/5/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java@1126
PS5, Line 1126: flatten
> nit: flattened
Done


http://gerrit.cloudera.org:8080/#/c/16007/5/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java@1136
PS5, Line 1136: gaurantee
> nit: guarantee
Done


http://gerrit.cloudera.org:8080/#/c/16007/7/testdata/workloads/functional-planner/queries/PlannerTest/tpcds-all.test
File testdata/workloads/functional-planner/queries/PlannerTest/tpcds-all.test:

http://gerrit.cloudera.org:8080/#/c/16007/7/testdata/workloads/functional-planner/queries/PlannerTest/tpcds-all.test@9036
PS7, Line 9036: |--90:EXCHANGE [UNPARTITIONED]
> On a related note, we probably *should* be doing a broadcast when the right
Ack


http://gerrit.cloudera.org:8080/#/c/16007/3/testdata/workloads/functional-query/queries/QueryTest/subquery.test
File testdata/workloads/functional-query/queries/QueryTest/subquery.test:

http://gerrit.cloudera.org:8080/#/c/16007/3/testdata/workloads/functional-query/queries/QueryTest/subquery.test@1044
PS3, Line 1044: select id, 1+(select min(id) from functional.alltypessmall)
> Would be useful to also add the Explain plan for some of these tests either
Done


http://gerrit.cloudera.org:8080/#/c/16007/3/testdata/workloads/functional-query/queries/QueryTest/subquery.test@1086
PS3, Line 1086: 
> Not sure what this means - without grouping?
Meant that the parent query had aggregation, and the outer and inner aggregations weren't
interfering. This is a good case for subquery coalescing / merging down the line.


http://gerrit.cloudera.org:8080/#/c/16007/3/testdata/workloads/tpcds/queries/tpcds-decimal_v2-q9.test
File testdata/workloads/tpcds/queries/tpcds-decimal_v2-q9.test:

http://gerrit.cloudera.org:8080/#/c/16007/3/testdata/workloads/tpcds/queries/tpcds-decimal_v2-q9.test@3
PS3, Line 3: select case when (select count(*)
> Cool that  this query is now supported. Can we also add the plan for this u
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/16007
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibcf55d26889aa01d69bb85f18c9241dda095fb66
Gerrit-Change-Number: 16007
Gerrit-PatchSet: 8
Gerrit-Owner: Shant Hovsepian <shant@cloudera.com>
Gerrit-Reviewer: Aman Sinha <amsinha@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fangyu.rao@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Gerrit-Reviewer: Shant Hovsepian <shant@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Comment-Date: Sat, 04 Jul 2020 19:33:29 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message