impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-7923: DecimalValue should be marked as packed
Date Fri, 03 Jul 2020 18:52:16 GMT
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16134 )

Change subject: IMPALA-7923: DecimalValue should be marked as packed
......................................................................


Patch Set 3:

I think scale factor 2 might be too small to get meaningful results - the query runtime is
probably dominated by the start-up time at that scale so might not capture differences in
execution. Could you maybe rerun with SF >= 10? That's usually enough so that startup time
is a smaller fraction.


-- 
To view, visit http://gerrit.cloudera.org:8080/16134
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I55f936a4f4f4b5faf129a9265222e64fc486b8ed
Gerrit-Change-Number: 16134
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <daniel.becker@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringhofer@cloudera.com>
Gerrit-Reviewer: Daniel Becker <daniel.becker@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Jul 2020 18:52:16 +0000
Gerrit-HasComments: No

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message