From reviews-return-76925-archive-asf-public=cust-asf.ponee.io@impala.apache.org Tue Apr 7 03:46:42 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 36BA1180647 for ; Tue, 7 Apr 2020 05:46:42 +0200 (CEST) Received: (qmail 93496 invoked by uid 500); 7 Apr 2020 03:46:41 -0000 Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.apache.org Received: (qmail 93483 invoked by uid 99); 7 Apr 2020 03:46:41 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Apr 2020 03:46:41 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id BE915181365 for ; Tue, 7 Apr 2020 03:46:40 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.574 X-Spam-Level: X-Spam-Status: No, score=0.574 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, RDNS_DYNAMIC=0.363, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 64urpIi7jM49 for ; Tue, 7 Apr 2020 03:46:39 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=75.101.130.251; helo=ip-10-146-233-104.ec2.internal; envelope-from=gerrit@cloudera.org; receiver= Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTPS id 7BCBBBB8C7 for ; Tue, 7 Apr 2020 03:46:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id 0373kcR3016455; Tue, 7 Apr 2020 03:46:38 GMT X-Gerrit-PatchSet: 3 Date: Tue, 7 Apr 2020 03:46:38 +0000 From: "Anonymous Coward (Code Review)" To: Marcel Kornacker , Lars Volker , Vihang Karajgaonkar , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Message-ID: X-Gerrit-MessageType: newchange Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-9590_Resolve_error_when_build_tsan_and_ubsan_on_arm64=0A?= X-Gerrit-Change-Id: I1b5b63e5e52bc818ea4591292ac36da941b2cf2d X-Gerrit-Change-Number: 15630 X-Gerrit-ChangeURL: X-Gerrit-Commit: 11fe19944680e639a2c574985b188e175cce79bf Reply-To: zhaorenhai@hotmail.com, lvolker@gmail.com, impala-cr@cloudera.com, marcelk@gmail.com, vihang@cloudera.com, tmate@cloudera.com, amsinha@cloudera.com, reviews@impala.incubator.apache.org, progers@cloudera.com MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.15 Content-Type: multipart/alternative; boundary="ZHTy49+LhmY="; charset=UTF-8 --ZHTy49+LhmY= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable zhaorenhai@hotmail=2Ecom has uploaded this change for review=2E ( http://ge= rrit=2Ecloudera=2Eorg:8080/15630 Change subject: IMPALA-9590 Resolve erro= r when build tsan and ubsan on arm64 =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E IMPALA-9590 Resolve error when build tsan and ubs= an on arm64 Tsan build will fail on atomicops-internals-x86=2Ecc build, so= if on arm64, just don't build it=2E And Ubsan build should link to libclan= g_rt=2Eubsan_standalone's =C2=A0aarch 64 version, not x86 version=2E Chang= e-Id: I1b5b63e5e52bc818ea4591292ac36da941b2cf2d --- M be/src/gutil/CMakeLis= ts=2Etxt M be/src/service/CMakeLists=2Etxt 2 files changed, 14 insertions(+= ), 2 deletions(-) git pull ssh://gerrit=2Ecloudera=2Eorg:29418/Impala-= ASF refs/changes/30/15630/3 -- To view, visit http://gerrit=2Ecloudera=2Eo= rg:8080/15630 To unsubscribe, visit http://gerrit=2Ecloudera=2Eorg:8080/set= tings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType:= newchange Gerrit-Change-Id: I1b5b63e5e52bc818ea4591292ac36da941b2cf2d Gerr= it-Change-Number: 15630 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward <= zhaorenhai@hotmail=2Ecom> --ZHTy49+LhmY=--