From reviews-return-77159-archive-asf-public=cust-asf.ponee.io@impala.apache.org Wed Apr 8 22:53:56 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id AAD4B18057A for ; Thu, 9 Apr 2020 00:53:55 +0200 (CEST) Received: (qmail 59556 invoked by uid 500); 8 Apr 2020 22:53:55 -0000 Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.apache.org Received: (qmail 59543 invoked by uid 99); 8 Apr 2020 22:53:54 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Apr 2020 22:53:54 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 356501A318E for ; Wed, 8 Apr 2020 22:53:54 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.574 X-Spam-Level: X-Spam-Status: No, score=0.574 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, RDNS_DYNAMIC=0.363, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id FRU_VVuY2CRv for ; Wed, 8 Apr 2020 22:53:52 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=75.101.130.251; helo=ip-10-146-233-104.ec2.internal; envelope-from=gerrit@cloudera.org; receiver= Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTPS id 8DF497FA88 for ; Wed, 8 Apr 2020 22:53:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id 038Mrn6S028289; Wed, 8 Apr 2020 22:53:49 GMT Message-Id: <202004082253.038Mrn6S028289@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 6 Date: Wed, 8 Apr 2020 22:53:49 +0000 From: "Sahil Takiar (Code Review)" To: David Knupp , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Impala Public Jenkins , Tim Armstrong , Joe McDonnell , Thomas Tauber-Marshall X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-9362=3A_Upgrade_sqlparse_0=2E1=2E19_-=3E_0=2E3=2E1=0A?= X-Gerrit-Change-Id: I77a1fd5ae311634a18ee04b8c389d8a3f3a6e001 X-Gerrit-Change-Number: 15642 X-Gerrit-ChangeURL: X-Gerrit-Commit: c5236cf9bf5590c85e9f84a7cfc51ebf4d4f6019 In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 8 Apr 2020 22:53:49 +0000 Reply-To: stakiar@cloudera.com, impala-cr@cloudera.com, dknupp@cloudera.com, marcelk@gmail.com, tarmstrong@cloudera.com, joemcdonnell@cloudera.com, impala-public-jenkins@cloudera.com, tmarshall@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.15 Content-Type: multipart/alternative; boundary="mgZ6hSUQmaM="; charset=UTF-8 --mgZ6hSUQmaM= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sahil Takiar has posted comments on this change=2E ( http://gerrit=2Ecloude= ra=2Eorg:8080/15642 ) Change subject: IMPALA-9362: Upgrade sqlparse 0=2E1= =2E19 -> 0=2E3=2E1 =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E Patch Set 6: Code-Review+1 LGTM pending the perf issues -- To = view, visit http://gerrit=2Ecloudera=2Eorg:8080/15642 To unsubscribe, visit= http://gerrit=2Ecloudera=2Eorg:8080/settings Gerrit-Project: Impala-ASF G= errit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77a1fd5= ae311634a18ee04b8c389d8a3f3a6e001 Gerrit-Change-Number: 15642 Gerrit-PatchS= et: 6 Gerrit-Owner: David Knupp Gerrit-Reviewer: Da= vid Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Thomas Tauber-Marshall Gerri= t-Reviewer: Tim Armstrong Gerrit-Comment-Date: = Wed, 08 Apr 2020 22:53:49 +0000 Gerrit-HasComments: No --mgZ6hSUQmaM=--