From reviews-return-77060-archive-asf-public=cust-asf.ponee.io@impala.apache.org Wed Apr 8 04:48:29 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id B8247180663 for ; Wed, 8 Apr 2020 06:48:28 +0200 (CEST) Received: (qmail 57505 invoked by uid 500); 8 Apr 2020 04:48:28 -0000 Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.apache.org Received: (qmail 57461 invoked by uid 99); 8 Apr 2020 04:48:26 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Apr 2020 04:48:26 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 362B21A31DC for ; Wed, 8 Apr 2020 04:48:26 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.574 X-Spam-Level: X-Spam-Status: No, score=0.574 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, RDNS_DYNAMIC=0.363, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id oZ8r5UvPhCMP for ; Wed, 8 Apr 2020 04:48:24 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=75.101.130.251; helo=ip-10-146-233-104.ec2.internal; envelope-from=gerrit@cloudera.org; receiver= Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTPS id 297857FA86 for ; Wed, 8 Apr 2020 04:48:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id 0384mMqP000998; Wed, 8 Apr 2020 04:48:22 GMT Message-Id: <202004080448.0384mMqP000998@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 5 Date: Wed, 8 Apr 2020 04:48:22 +0000 From: "Xiaomeng Zhang (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-8632=3A_Add_support_for_self-event_detection_for_insert_events=0A?= X-Gerrit-Change-Id: I7873fbb2c159343690f93b9d120f6b425b983dcf X-Gerrit-Change-Number: 15648 X-Gerrit-ChangeURL: X-Gerrit-Commit: 0cd24e9d2a4cd29557e18687c75072de809530db In-Reply-To: References: Reply-To: xiaomeng@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com, vihang@cloudera.com, amsinha@cloudera.com, reviews@impala.incubator.apache.org, progers@cloudera.com MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.15 Content-Type: multipart/alternative; boundary="zOqa2C3wS3E="; charset=UTF-8 --zOqa2C3wS3E= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Xiaomeng Zhang has uploaded a new patch set (#5)=2E ( http://gerrit=2Ecloud= era=2Eorg:8080/15648 ) Change subject: IMPALA-8632: Add support for self-e= vent detection for insert events =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E IMPALA-8632: Add support for self-event detection for i= nsert events In case of INSERT_EVENTS if Impala inserts into a table it ca= uses a refresh to the underlying table/partition=2E This could be unnecessa= ry when there is only one Impala cluster in the system=2E We can detect a s= elf-event in such cases when the HMS API to fire a listener event returns t= he event id=2E This is used by EventProcessor to ignore the event when it i= s fetched later in the next polling cycle=2E Testing: Add testInsertFromIm= pala() in MetastoreEventsProcessorTest=2Ejava to test insert event self-eve= nt detection when insert into table and partition=2E Change-Id: I7873fbb2c= 159343690f93b9d120f6b425b983dcf --- M be/src/common/global-flags=2Ecc M be/= src/util/backend-gflag-util=2Ecc M bin/impala-config=2Esh M common/thrift/B= ackendGflags=2Ethrift M fe/src/compat-hive-2/java/org/apache/impala/compat/= MetastoreShim=2Ejava M fe/src/compat-hive-3/java/org/apache/impala/compat/M= etastoreShim=2Ejava M fe/src/main/java/org/apache/impala/catalog/CatalogSer= viceCatalog=2Ejava M fe/src/main/java/org/apache/impala/catalog/Db=2Ejava M= fe/src/main/java/org/apache/impala/catalog/HdfsPartition=2Ejava M fe/src/m= ain/java/org/apache/impala/catalog/Table=2Ejava M fe/src/main/java/org/apac= he/impala/catalog/events/InFlightEvents=2Ejava M fe/src/main/java/org/apach= e/impala/catalog/events/MetastoreEvents=2Ejava M fe/src/main/java/org/apach= e/impala/catalog/events/SelfEventContext=2Ejava M fe/src/main/java/org/apac= he/impala/service/BackendConfig=2Ejava M fe/src/main/java/org/apache/impala= /service/CatalogOpExecutor=2Ejava M fe/src/main/java/org/apache/impala/util= /MetaStoreUtil=2Ejava M fe/src/test/java/org/apache/impala/catalog/events/M= etastoreEventsProcessorTest=2Ejava M tests/custom_cluster/test_event_proces= sing=2Epy 18 files changed, 487 insertions(+), 171 deletions(-) git pul= l ssh://gerrit=2Ecloudera=2Eorg:29418/Impala-ASF refs/changes/48/15648/5 --= To view, visit http://gerrit=2Ecloudera=2Eorg:8080/15648 To unsubscribe, = visit http://gerrit=2Ecloudera=2Eorg:8080/settings Gerrit-Project: Impala-= ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id:= I7873fbb2c159343690f93b9d120f6b425b983dcf Gerrit-Change-Number: 15648 Gerr= it-PatchSet: 5 Gerrit-Owner: Xiaomeng Zhang Gerri= t-Reviewer: Anurag Mantripragada Gerrit-Reviewer: I= mpala Public Jenkins Gerrit-Reviewer= : Vihang Karajgaonkar Gerrit-Reviewer: Xiaomeng Zha= ng --zOqa2C3wS3E=--