From reviews-return-77044-archive-asf-public=cust-asf.ponee.io@impala.apache.org Wed Apr 8 01:46:16 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 58014180663 for ; Wed, 8 Apr 2020 03:46:16 +0200 (CEST) Received: (qmail 77466 invoked by uid 500); 8 Apr 2020 01:46:15 -0000 Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.apache.org Received: (qmail 77454 invoked by uid 99); 8 Apr 2020 01:46:15 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Apr 2020 01:46:15 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id C2AD21A4193 for ; Wed, 8 Apr 2020 01:46:14 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.574 X-Spam-Level: X-Spam-Status: No, score=0.574 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, RDNS_DYNAMIC=0.363, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id PBrYCTIr5Y4D for ; Wed, 8 Apr 2020 01:46:13 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=75.101.130.251; helo=ip-10-146-233-104.ec2.internal; envelope-from=gerrit@cloudera.org; receiver= Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTPS id B42C0BB8ED for ; Wed, 8 Apr 2020 01:46:13 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id 0381kCVM026410; Wed, 8 Apr 2020 01:46:12 GMT Message-Id: <202004080146.0381kCVM026410@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 5 Date: Wed, 8 Apr 2020 01:46:12 +0000 From: "Aman Sinha (Code Review)" To: Quanlong Huang , Impala Public Jenkins , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Csaba Ringhofer , Vihang Karajgaonkar , Fang-Yu Rao X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-9529=3A_Fix_multi-tuple_predicates_not_assigned_in_column_masking=0A?= X-Gerrit-Change-Id: I12f1b59733db5a88324bb0c16085f565edc306b3 X-Gerrit-Change-Number: 15654 X-Gerrit-ChangeURL: X-Gerrit-Commit: 5c2cae89f2ba1de55131a261dce7c8e284bb6c0e In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 8 Apr 2020 01:46:12 +0000 Reply-To: amsinha@cloudera.com, impala-cr@cloudera.com, fangyu.rao@cloudera.com, marcelk@gmail.com, vihang@cloudera.com, csringhofer@cloudera.com, impala-public-jenkins@cloudera.com, reviews@impala.incubator.apache.org, huangquanlong@gmail.com MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.15 Content-Type: multipart/alternative; boundary="UaQIIKW6NJw="; charset=UTF-8 --UaQIIKW6NJw= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Aman Sinha has posted comments on this change=2E ( http://gerrit=2Ecloudera= =2Eorg:8080/15654 ) Change subject: IMPALA-9529: Fix multi-tuple predicate= s not assigned in column masking =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E Patch Set 5: (1 comment) http://gerrit=2Ecloudera=2E= org:8080/#/c/15654/3/fe/src/main/java/org/apache/impala/analysis/Analyzer= =2Ejava File fe/src/main/java/org/apache/impala/analysis/Analyzer=2Ejava: = http://gerrit=2Ecloudera=2Eorg:8080/#/c/15654/3/fe/src/main/java/org/apache= /impala/analysis/Analyzer=2Ejava@1493 PS3, Line 1493: if (node instance= of JoinNode) { > I'm afraid that doesn't work since JoinNode=2Einit() is ca= lling this method t Ok, that makes sense=2E Thanks=2E -- To view, visi= t http://gerrit=2Ecloudera=2Eorg:8080/15654 To unsubscribe, visit http://ge= rrit=2Ecloudera=2Eorg:8080/settings Gerrit-Project: Impala-ASF Gerrit-Bran= ch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12f1b59733db5a883= 24bb0c16085f565edc306b3 Gerrit-Change-Number: 15654 Gerrit-PatchSet: 5 Gerr= it-Owner: Quanlong Huang Gerrit-Reviewer: Aman = Sinha Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Rev= iewer: Vihang Karajgaonkar Gerrit-Comment-Date: Wed= , 08 Apr 2020 01:46:12 +0000 Gerrit-HasComments: Yes --UaQIIKW6NJw=--