From reviews-return-76947-archive-asf-public=cust-asf.ponee.io@impala.apache.org Tue Apr 7 07:48:06 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id B674B180663 for ; Tue, 7 Apr 2020 09:48:05 +0200 (CEST) Received: (qmail 82494 invoked by uid 500); 7 Apr 2020 07:48:05 -0000 Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.apache.org Received: (qmail 82482 invoked by uid 99); 7 Apr 2020 07:48:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Apr 2020 07:48:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 2F61DC0B11 for ; Tue, 7 Apr 2020 07:48:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.574 X-Spam-Level: X-Spam-Status: No, score=0.574 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, RDNS_DYNAMIC=0.363, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id Jd4DV2f1rHX0 for ; Tue, 7 Apr 2020 07:48:02 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=75.101.130.251; helo=ip-10-146-233-104.ec2.internal; envelope-from=gerrit@cloudera.org; receiver= Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTPS id 80796BB8DF for ; Tue, 7 Apr 2020 07:48:02 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id 0377m199020274; Tue, 7 Apr 2020 07:48:01 GMT Message-Id: <202004070748.0377m199020274@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 4 Date: Tue, 7 Apr 2020 07:48:01 +0000 From: "Adam Tamas (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-8980=3A_Remove_functional*=2Ealltypesinsert_from_EE_tests=0A?= X-Gerrit-Change-Id: I257e936868917a2fcc6c030f6c855b247e8a0eea X-Gerrit-Change-Number: 15529 X-Gerrit-ChangeURL: X-Gerrit-Commit: b8e29abd12928908aa7dfd70d1a7e042b87ef4e6 In-Reply-To: References: Reply-To: tadam@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com, vihang@cloudera.com, amsinha@cloudera.com, reviews@impala.incubator.apache.org, progers@cloudera.com MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.15 Content-Type: multipart/alternative; boundary="bevNhhpHH4g="; charset=UTF-8 --bevNhhpHH4g= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Adam Tamas has uploaded a new patch set (#4)=2E ( http://gerrit=2Ecloudera= =2Eorg:8080/15529 ) Change subject: IMPALA-8980: Remove functional*=2Eallt= ypesinsert from EE tests =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E IMPALA-8980: Remove functional*=2Ealltypesinsert from EE test= s -Modified the =E2=80=98test_insert=2Epy=E2=80=99 so the tests can run pa= rallel=2E -Every test will create its own temporary tables for insert tes= ting=2E -Swapped out the SETUP tags to Truncate table QUERY statement=2E = -Becouse the SETUP tag is not used anymore, the correspondig code was re= moved=2E -A test query in =E2=80=98insert=2Etest=E2=80=99=2E The test was i= ncorrect so modified to test for the right behavior=2E Testing: -tests/run= -tests=2Epy query_test/test_insert=2Epy -impala-py=2Etest tests/query_test/= test_insert=2Epy -the same for test_insert_permutation=2Epy and test_load= =2Epy Change-Id: I257e936868917a2fcc6c030f6c855b247e8a0eea --- M testdata/= datasets/functional/functional_schema_template=2Esql M testdata/workloads/f= unctional-query/queries/QueryTest/insert-mem-limit=2Etest M testdata/worklo= ads/functional-query/queries/QueryTest/insert=2Etest M testdata/workloads/f= unctional-query/queries/QueryTest/insert_bad_expr=2Etest M testdata/workloa= ds/functional-query/queries/QueryTest/insert_null=2Etest M testdata/workloa= ds/functional-query/queries/QueryTest/insert_overwrite=2Etest M testdata/wo= rkloads/functional-query/queries/QueryTest/insert_permutation=2Etest M test= data/workloads/functional-query/queries/QueryTest/load=2Etest M testdata/wo= rkloads/functional-query/queries/QueryTest/show=2Etest M tests/common/impal= a_test_suite=2Epy M tests/custom_cluster/test_mt_dop=2Epy M tests/query_tes= t/test_insert=2Epy M tests/query_test/test_mt_dop=2Epy 13 files changed, 14= 7 insertions(+), 266 deletions(-) git pull ssh://gerrit=2Ecloudera=2Eor= g:29418/Impala-ASF refs/changes/29/15529/4 -- To view, visit http://gerrit= =2Ecloudera=2Eorg:8080/15529 To unsubscribe, visit http://gerrit=2Ecloudera= =2Eorg:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerr= it-MessageType: newpatchset Gerrit-Change-Id: I257e936868917a2fcc6c030f6c85= 5b247e8a0eea Gerrit-Change-Number: 15529 Gerrit-PatchSet: 4 Gerrit-Owner: A= dam Tamas Gerrit-Reviewer: Adam Tamas Gerrit-Reviewer: Csaba Ringhofer Gerr= it-Reviewer: Gabor Kaszab Gerrit-Reviewer: Imp= ala Public Jenkins --bevNhhpHH4g=--