From reviews-return-76800-archive-asf-public=cust-asf.ponee.io@impala.apache.org Thu Apr 2 11:11:07 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 10BB4180626 for ; Thu, 2 Apr 2020 13:11:06 +0200 (CEST) Received: (qmail 74583 invoked by uid 500); 2 Apr 2020 11:11:06 -0000 Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.apache.org Received: (qmail 74559 invoked by uid 99); 2 Apr 2020 11:11:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Apr 2020 11:11:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id B96E0C0163 for ; Thu, 2 Apr 2020 11:11:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.574 X-Spam-Level: X-Spam-Status: No, score=0.574 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, RDNS_DYNAMIC=0.363, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 9C9Kmr9TBWjt for ; Thu, 2 Apr 2020 11:11:04 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=75.101.130.251; helo=ip-10-146-233-104.ec2.internal; envelope-from=gerrit@cloudera.org; receiver= Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTPS id C70CD7DC60 for ; Thu, 2 Apr 2020 11:11:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id 032BB2KY002976; Thu, 2 Apr 2020 11:11:02 GMT Message-Id: <202004021111.032BB2KY002976@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 4 Date: Thu, 2 Apr 2020 11:11:02 +0000 From: "Impala Public Jenkins (Code Review)" To: Tim Armstrong , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: merged Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-7138=3A_detect_devicemapper_volumes_correctly=0A?= X-Gerrit-Change-Id: I9d231bcf9105db8d4ab03586eab74e0644337a6f X-Gerrit-Change-Number: 15631 X-Gerrit-ChangeURL: X-Gerrit-Commit: 7abbde3c5d18217a84979454fffad1887e10816a In-Reply-To: References: Reply-To: impala-public-jenkins@cloudera.com, impala-cr@cloudera.com, tarmstrong@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.15 Content-Type: multipart/alternative; boundary="XXZ82NpLsqs="; charset=UTF-8 --XXZ82NpLsqs= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Impala Public Jenkins has submitted this change and it was merged=2E ( http= ://gerrit=2Ecloudera=2Eorg:8080/15631 ) Change subject: IMPALA-7138: detec= t devicemapper volumes correctly =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E IMPALA-7138: detect devicemapper volumes correctly Thi= s is a more general fix for device detection that disables the digit-stripp= ing heuristic if a device with the same name as a partition already exists= =2E E=2Eg=2E for device-mapper devices, /proc/partitions might include a p= artition called "dm-0" that maps directly to the block device "dm-0" (i=2Ee= =2E /sys/block/dm-0)=2E Before this fix, we looked for a device called "dm-= ", which did not exist=2E Testing: Created a dummy device-mapper device wi= th the following command: sudo dmsetup create 1gb-zero --table '0 195312= 5 zero' Then confirmed that the device name in the logs was correct d= m-0 (rotational=3Dtrue) Other devices - sda, sda1, sda2, sdb, sdb1, etc on= my system were still detected the same as before=2E Change-Id: I9d231bcf9= 105db8d4ab03586eab74e0644337a6f Reviewed-on: http://gerrit=2Ecloudera=2Eorg= :8080/15631 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/util/disk-info=2Ecc M be/src/util/filesystem-util-test= =2Ecc M be/src/util/filesystem-util=2Ecc M be/src/util/filesystem-util=2Eh = 4 files changed, 74 insertions(+), 15 deletions(-) Approvals: Impala Pub= lic Jenkins: Looks good to me, approved; Verified -- To view, visit http:= //gerrit=2Ecloudera=2Eorg:8080/15631 To unsubscribe, visit http://gerrit=2E= cloudera=2Eorg:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: mas= ter Gerrit-MessageType: merged Gerrit-Change-Id: I9d231bcf9105db8d4ab03586e= ab74e0644337a6f Gerrit-Change-Number: 15631 Gerrit-PatchSet: 4 Gerrit-Owner= : Tim Armstrong Gerrit-Reviewer: Impala Public = Jenkins Gerrit-Reviewer: Joe McDonne= ll Gerrit-Reviewer: Tim Armstrong --XXZ82NpLsqs=--