From reviews-return-76981-apmail-impala-reviews-archive=impala.apache.org@impala.apache.org Tue Apr 7 15:58:43 2020 Return-Path: X-Original-To: apmail-impala-reviews-archive@minotaur.apache.org Delivered-To: apmail-impala-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 0E59C1914B for ; Tue, 7 Apr 2020 15:58:42 +0000 (UTC) Received: (qmail 48722 invoked by uid 500); 7 Apr 2020 15:58:42 -0000 Delivered-To: apmail-impala-reviews-archive@impala.apache.org Received: (qmail 48695 invoked by uid 500); 7 Apr 2020 15:58:41 -0000 Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.apache.org Received: (qmail 48683 invoked by uid 99); 7 Apr 2020 15:58:41 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Apr 2020 15:58:41 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 0EF4EC227B for ; Tue, 7 Apr 2020 15:58:41 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.574 X-Spam-Level: X-Spam-Status: No, score=0.574 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, RDNS_DYNAMIC=0.363, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id wDPv1M8B8i-G for ; Tue, 7 Apr 2020 15:58:39 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=75.101.130.251; helo=ip-10-146-233-104.ec2.internal; envelope-from=gerrit@cloudera.org; receiver= Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTPS id 69C7DBB8E0 for ; Tue, 7 Apr 2020 15:58:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id 037FwZjT030951; Tue, 7 Apr 2020 15:58:35 GMT Message-Id: <202004071558.037FwZjT030951@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 9 Date: Tue, 7 Apr 2020 15:58:32 +0000 From: "Tim Armstrong (Code Review)" To: zhaorenhai@hotmail.com, impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Impala Public Jenkins X-Gerrit-MessageType: merged Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-9545_Decide_cacheline_size_of_aarch64=0A?= X-Gerrit-Change-Id: Id56bfa63e4b6cd957c4997f10de78a5f4111f61f X-Gerrit-Change-Number: 15555 X-Gerrit-ChangeURL: X-Gerrit-Commit: dbd22365fdaf56b1a76ba8d3b6460222f809090f In-Reply-To: References: Reply-To: tarmstrong@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com, twood@cloudera.com, zhaorenhai@hotmail.com, impala-public-jenkins@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.15 Content-Type: multipart/alternative; boundary="vEkYEq0/NIY="; charset=UTF-8 --vEkYEq0/NIY= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Tim Armstrong has submitted this change and it was merged=2E ( http://gerri= t=2Ecloudera=2Eorg:8080/15555 ) Change subject: IMPALA-9545 Decide cacheli= ne size of aarch64 =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E IMPALA-9545 Decide cacheline size of aarch64 ARM64's L3 cacheline = size is different according to CPU vendor's architecture=2E If user define= d CACHELINESIZE_AARCH64 in impala-config-local=2Esh, then we will use that= value, if user did not define it, then we will get the value from OS, if = fail, then we will use the default value 64=2E Change-Id: Id56bfa63e4b6cd9= 57c4997f10de78a5f4111f61f Reviewed-on: http://gerrit=2Ecloudera=2Eorg:8080/= 15555 Reviewed-by: Tim Armstrong Tested-by: Imp= ala Public Jenkins --- M CMakeLists= =2Etxt M be/CMakeLists=2Etxt M be/src/gutil/port=2Eh M buildall=2Esh 4 file= s changed, 32 insertions(+), 0 deletions(-) Approvals: Tim Armstrong: Lo= oks good to me, approved Impala Public Jenkins: Verified -- To view, vi= sit http://gerrit=2Ecloudera=2Eorg:8080/15555 To unsubscribe, visit http://= gerrit=2Ecloudera=2Eorg:8080/settings Gerrit-Project: Impala-ASF Gerrit-Br= anch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id56bfa63e4b6cd95= 7c4997f10de78a5f4111f61f Gerrit-Change-Number: 15555 Gerrit-PatchSet: 9 Ger= rit-Owner: Anonymous Coward Gerrit-Reviewer: Ano= nymous Coward Gerrit-Reviewer: Impala Public Jen= kins Gerrit-Reviewer: Tim Armstrong = --vEkYEq0/NIY=--