From reviews-return-76838-apmail-impala-reviews-archive=impala.apache.org@impala.apache.org Thu Apr 2 20:48:34 2020 Return-Path: X-Original-To: apmail-impala-reviews-archive@minotaur.apache.org Delivered-To: apmail-impala-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id B1E3419377 for ; Thu, 2 Apr 2020 20:48:33 +0000 (UTC) Received: (qmail 5138 invoked by uid 500); 2 Apr 2020 20:48:33 -0000 Delivered-To: apmail-impala-reviews-archive@impala.apache.org Received: (qmail 5120 invoked by uid 500); 2 Apr 2020 20:48:33 -0000 Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.apache.org Received: (qmail 5108 invoked by uid 99); 2 Apr 2020 20:48:32 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Apr 2020 20:48:32 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id A2256C223F for ; Thu, 2 Apr 2020 20:48:31 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.574 X-Spam-Level: X-Spam-Status: No, score=0.574 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, RDNS_DYNAMIC=0.363, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id gjwnxh5SnI0H for ; Thu, 2 Apr 2020 20:48:28 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=75.101.130.251; helo=ip-10-146-233-104.ec2.internal; envelope-from=gerrit@cloudera.org; receiver= Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTPS id E46E57DC60 for ; Thu, 2 Apr 2020 20:48:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id 032KmQFO018572; Thu, 2 Apr 2020 20:48:26 GMT Message-Id: <202004022048.032KmQFO018572@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 6 Date: Thu, 2 Apr 2020 20:48:26 +0000 From: "David Knupp (Code Review)" To: Laszlo Gaal , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Impala Public Jenkins , Tim Armstrong , Joe McDonnell X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_Use_Python_from_the_toolchain_for_Impala=0A?= X-Gerrit-Change-Id: Ic7b40cef89cfb3b467b61b2d54a94e708642882b X-Gerrit-Change-Number: 15624 X-Gerrit-ChangeURL: X-Gerrit-Commit: ebdafdbe885168a470ca88f139e209fdde1f370c In-Reply-To: References: X-Gerrit-Comment-Date: Thu, 2 Apr 2020 20:48:26 +0000 Reply-To: dknupp@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com, tarmstrong@cloudera.com, joemcdonnell@cloudera.com, laszlo.gaal@cloudera.com, impala-public-jenkins@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.15 Content-Type: multipart/alternative; boundary="IRo4fOFJKRo="; charset=UTF-8 --IRo4fOFJKRo= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable David Knupp has posted comments on this change=2E ( http://gerrit=2Eclouder= a=2Eorg:8080/15624 ) Change subject: Use Python from the toolchain for Imp= ala =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E Patch = Set 6: (2 comments) http://gerrit=2Ecloudera=2Eorg:8080/#/c/15624/6//COMM= IT_MSG Commit Message: http://gerrit=2Ecloudera=2Eorg:8080/#/c/15624/6//CO= MMIT_MSG@17 PS6, Line 17: mative Nit: native http://gerrit=2Ecloudera=2Eo= rg:8080/#/c/15624/6//COMMIT_MSG@20 PS6, Line 20: Python2 : vers= ion from the toolchain This is larger question, but would we ever consider = having both python3 and python2 in the toolchain? The impala-shell will be = python3 compatible before the rest of the python code, e=2Eg=2E the test ha= rness, is python3 compatible, but it would be good to have both versions on= hand to test changes to shell=2E -- To view, visit http://gerrit=2Eclo= udera=2Eorg:8080/15624 To unsubscribe, visit http://gerrit=2Ecloudera=2Eorg= :8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Mes= sageType: comment Gerrit-Change-Id: Ic7b40cef89cfb3b467b61b2d54a94e70864288= 2b Gerrit-Change-Number: 15624 Gerrit-PatchSet: 6 Gerrit-Owner: Laszlo Gaal= Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell G= errit-Reviewer: Laszlo Gaal Gerrit-Reviewer:= Tim Armstrong Gerrit-Comment-Date: Thu, 02 Apr= 2020 20:48:26 +0000 Gerrit-HasComments: Yes --IRo4fOFJKRo=--