impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-8857: Fix flaky Kudu tests with external inserts
Date Wed, 01 Apr 2020 21:51:37 GMT
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15633


Change subject: IMPALA-8857: Fix flaky Kudu tests with external inserts
......................................................................

IMPALA-8857: Fix flaky Kudu tests with external inserts

There are several Kudu related tests that are inherently flaky because
they insert rows into a Kudu table from the python Kudu client and
then scan the table from an Impala client even though no guarantees
are made about the consistency of operations from different clients.

This patch fixes this by adding a query option
'kudu_snapshot_read_timestamp_micros' which sets the timestamp at
which to perform Kudu snapshot reads.

The tests are then modified to set the timestamp to be equal to the
latest observed timestamp returned by the client that did the inserts
(plus 1 microsecond which the Kudu python client adds automatically
in latest_observed_timestamp() for this use case).

Change-Id: I5b787f6542dc31dcd846f19576a060a89aec891d
---
M be/src/exec/kudu-scanner.cc
M be/src/service/query-options.cc
M be/src/service/query-options.h
M common/thrift/ImpalaInternalService.thrift
M common/thrift/ImpalaService.thrift
M tests/query_test/test_kudu.py
6 files changed, 43 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/15633/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15633
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5b787f6542dc31dcd846f19576a060a89aec891d
Gerrit-Change-Number: 15633
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message