impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1
Date Fri, 17 Apr 2020 05:04:25 GMT
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15642
)

Change subject: IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1
......................................................................

IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1

Upgrades the impala-shell's bundled version of sqlparse to 0.3.1.
There were some API changes in 0.2.0+ that required a re-write of
the StripLeadingCommentFilter in impala_shell.py. A slight perf
optimization was also added to avoid using the filter altogether
if no leading comment is readily discernible.

As 0.1.19 was the last version of sqlparse to support python 2.6,
this patch also breaks Impala's compatibility with python 2.6.

No new tests were added, but all existing tests passed without
modification.

Change-Id: I77a1fd5ae311634a18ee04b8c389d8a3f3a6e001
Reviewed-on: http://gerrit.cloudera.org:8080/15642
Reviewed-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
---
M LICENSE.txt
M README.md
M bin/rat_exclude_files.txt
M infra/python/deps/requirements.txt
M shell/.gitignore
D shell/ext-py/sqlparse-0.1.19/.travis.yml
D shell/ext-py/sqlparse-0.1.19/AUTHORS
D shell/ext-py/sqlparse-0.1.19/CHANGES
D shell/ext-py/sqlparse-0.1.19/README.rst
D shell/ext-py/sqlparse-0.1.19/bin/sqlformat
D shell/ext-py/sqlparse-0.1.19/docs/source/analyzing.rst
D shell/ext-py/sqlparse-0.1.19/docs/source/api.rst
D shell/ext-py/sqlparse-0.1.19/docs/source/changes.rst
D shell/ext-py/sqlparse-0.1.19/docs/source/conf.py
D shell/ext-py/sqlparse-0.1.19/docs/source/index.rst
D shell/ext-py/sqlparse-0.1.19/docs/source/indices.rst
D shell/ext-py/sqlparse-0.1.19/docs/source/intro.rst
D shell/ext-py/sqlparse-0.1.19/docs/source/ui.rst
D shell/ext-py/sqlparse-0.1.19/docs/sqlformat.1
D shell/ext-py/sqlparse-0.1.19/pytest.ini
D shell/ext-py/sqlparse-0.1.19/setup.py
D shell/ext-py/sqlparse-0.1.19/sqlparse/engine/__init__.py
D shell/ext-py/sqlparse-0.1.19/sqlparse/engine/filter.py
D shell/ext-py/sqlparse-0.1.19/sqlparse/engine/grouping.py
D shell/ext-py/sqlparse-0.1.19/sqlparse/exceptions.py
D shell/ext-py/sqlparse-0.1.19/sqlparse/filters.py
D shell/ext-py/sqlparse-0.1.19/sqlparse/formatter.py
D shell/ext-py/sqlparse-0.1.19/sqlparse/functions.py
D shell/ext-py/sqlparse-0.1.19/sqlparse/keywords.py
D shell/ext-py/sqlparse-0.1.19/sqlparse/lexer.py
D shell/ext-py/sqlparse-0.1.19/sqlparse/pipeline.py
D shell/ext-py/sqlparse-0.1.19/sqlparse/sql.py
D shell/ext-py/sqlparse-0.1.19/sqlparse/tokens.py
D shell/ext-py/sqlparse-0.1.19/sqlparse/utils.py
D shell/ext-py/sqlparse-0.1.19/tests/test_filters.py
D shell/ext-py/sqlparse-0.1.19/tests/test_format.py
D shell/ext-py/sqlparse-0.1.19/tests/test_functions.py
D shell/ext-py/sqlparse-0.1.19/tests/test_grouping.py
D shell/ext-py/sqlparse-0.1.19/tests/test_parse.py
D shell/ext-py/sqlparse-0.1.19/tests/test_pipeline.py
D shell/ext-py/sqlparse-0.1.19/tests/test_regressions.py
D shell/ext-py/sqlparse-0.1.19/tests/test_split.py
D shell/ext-py/sqlparse-0.1.19/tests/test_tokenize.py
D shell/ext-py/sqlparse-0.1.19/tests/utils.py
D shell/ext-py/sqlparse-0.1.19/tox.ini
A shell/ext-py/sqlparse-0.3.1/AUTHORS
A shell/ext-py/sqlparse-0.3.1/CHANGELOG
R shell/ext-py/sqlparse-0.3.1/LICENSE
R shell/ext-py/sqlparse-0.3.1/MANIFEST.in
A shell/ext-py/sqlparse-0.3.1/README.rst
R shell/ext-py/sqlparse-0.3.1/TODO
A shell/ext-py/sqlparse-0.3.1/setup.cfg
A shell/ext-py/sqlparse-0.3.1/setup.py
R shell/ext-py/sqlparse-0.3.1/sqlparse/__init__.py
A shell/ext-py/sqlparse-0.3.1/sqlparse/__main__.py
A shell/ext-py/sqlparse-0.3.1/sqlparse/cli.py
A shell/ext-py/sqlparse-0.3.1/sqlparse/compat.py
A shell/ext-py/sqlparse-0.3.1/sqlparse/engine/__init__.py
A shell/ext-py/sqlparse-0.3.1/sqlparse/engine/filter_stack.py
A shell/ext-py/sqlparse-0.3.1/sqlparse/engine/grouping.py
A shell/ext-py/sqlparse-0.3.1/sqlparse/engine/statement_splitter.py
A shell/ext-py/sqlparse-0.3.1/sqlparse/exceptions.py
A shell/ext-py/sqlparse-0.3.1/sqlparse/filters/__init__.py
A shell/ext-py/sqlparse-0.3.1/sqlparse/filters/aligned_indent.py
A shell/ext-py/sqlparse-0.3.1/sqlparse/filters/others.py
A shell/ext-py/sqlparse-0.3.1/sqlparse/filters/output.py
A shell/ext-py/sqlparse-0.3.1/sqlparse/filters/reindent.py
A shell/ext-py/sqlparse-0.3.1/sqlparse/filters/right_margin.py
A shell/ext-py/sqlparse-0.3.1/sqlparse/filters/tokens.py
A shell/ext-py/sqlparse-0.3.1/sqlparse/formatter.py
A shell/ext-py/sqlparse-0.3.1/sqlparse/keywords.py
A shell/ext-py/sqlparse-0.3.1/sqlparse/lexer.py
A shell/ext-py/sqlparse-0.3.1/sqlparse/sql.py
A shell/ext-py/sqlparse-0.3.1/sqlparse/tokens.py
A shell/ext-py/sqlparse-0.3.1/sqlparse/utils.py
R shell/ext-py/sqlparse-0.3.1/tests/__init__.py
A shell/ext-py/sqlparse-0.3.1/tests/conftest.py
R shell/ext-py/sqlparse-0.3.1/tests/files/_Make_DirEntry.sql
R shell/ext-py/sqlparse-0.3.1/tests/files/begintag.sql
R shell/ext-py/sqlparse-0.3.1/tests/files/begintag_2.sql
R shell/ext-py/sqlparse-0.3.1/tests/files/dashcomment.sql
A shell/ext-py/sqlparse-0.3.1/tests/files/encoding_gbk.sql
A shell/ext-py/sqlparse-0.3.1/tests/files/encoding_utf8.sql
R shell/ext-py/sqlparse-0.3.1/tests/files/function.sql
R shell/ext-py/sqlparse-0.3.1/tests/files/function_psql.sql
R shell/ext-py/sqlparse-0.3.1/tests/files/function_psql2.sql
R shell/ext-py/sqlparse-0.3.1/tests/files/function_psql3.sql
A shell/ext-py/sqlparse-0.3.1/tests/files/function_psql4.sql
R shell/ext-py/sqlparse-0.3.1/tests/files/huge_select.sql
A shell/ext-py/sqlparse-0.3.1/tests/files/stream.sql
R shell/ext-py/sqlparse-0.3.1/tests/files/test_cp1251.sql
A shell/ext-py/sqlparse-0.3.1/tests/test_cli.py
A shell/ext-py/sqlparse-0.3.1/tests/test_format.py
A shell/ext-py/sqlparse-0.3.1/tests/test_grouping.py
A shell/ext-py/sqlparse-0.3.1/tests/test_keywords.py
A shell/ext-py/sqlparse-0.3.1/tests/test_parse.py
A shell/ext-py/sqlparse-0.3.1/tests/test_regressions.py
A shell/ext-py/sqlparse-0.3.1/tests/test_split.py
A shell/ext-py/sqlparse-0.3.1/tests/test_tokenize.py
A shell/ext-py/sqlparse-0.3.1/tox.ini
M shell/impala_shell.py
M shell/packaging/requirements.txt
M tests/shell/test_shell_commandline.py
103 files changed, 7,535 insertions(+), 6,883 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/15642
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I77a1fd5ae311634a18ee04b8c389d8a3f3a6e001
Gerrit-Change-Number: 15642
Gerrit-PatchSet: 10
Gerrit-Owner: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <stakiar@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message