impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Laszlo Gaal (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-9629: Add CentOS 8.1 support to bootstrap system.sh
Date Fri, 10 Apr 2020 17:12:25 GMT
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/15623 )

Change subject: IMPALA-9629: Add CentOS 8.1 support to bootstrap_system.sh
......................................................................


Patch Set 12: Code-Review+1

(3 comments)

IMPALA_TOOLCHAIN_BUILD_ID bumped to an officially published one containing Centos8 binaries.

Carry +1 from Tim

http://gerrit.cloudera.org:8080/#/c/15623/6//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15623/6//COMMIT_MSG@18
PS6, Line 18: snappy-devel moved to the PowerTools repo, so it needs to be installed
            :   from there
> delete this: curl was added for the no-NTP patch
Done


http://gerrit.cloudera.org:8080/#/c/15623/5/bin/bootstrap_system.sh
File bin/bootstrap_system.sh:

http://gerrit.cloudera.org:8080/#/c/15623/5/bin/bootstrap_system.sh@266
PS5, Line 266:     # 1. Link pip's version to Python's version
> TL;DR: Impala (minus the shell) is still Python2 dependent, and Impala deve
Filed IMPALA-9627 for the utility scripts


http://gerrit.cloudera.org:8080/#/c/15623/5/bin/bootstrap_system.sh@367
PS5, Line 367:   "pg_ctl start -w --timeout=120 >> /var/lib/pgsql/pg.log 2>&1"
> Yes, the support matrix grew large enough (redhat[6]/7/8, Ubuntu 14/16/18[/
filed IMPALA-9628



-- 
To view, visit http://gerrit.cloudera.org:8080/15623
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3df5d48eca7a10219264e3604a4f05f072188e6e
Gerrit-Change-Number: 15623
Gerrit-PatchSet: 12
Gerrit-Owner: Laszlo Gaal <laszlo.gaal@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <laszlo.gaal@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <boroknagyz@cloudera.com>
Gerrit-Comment-Date: Fri, 10 Apr 2020 17:12:25 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message