impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sahil Takiar (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5746: Test case for remote fragments releasing memory
Date Thu, 09 Apr 2020 21:46:41 GMT
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15666 )

Change subject: IMPALA-5746: Test case for remote fragments releasing memory
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15666/1/tests/custom_cluster/test_restart_services.py
File tests/custom_cluster/test_restart_services.py:

http://gerrit.cloudera.org:8080/#/c/15666/1/tests/custom_cluster/test_restart_services.py@240
PS1, Line 240: status_report_max_retry_s
> Great.

Maybe I spoke too soon, I'm running a more complex query and it doesn't look like resources
are getting released immediately. Will make some comments on the JIRA once I have a better
idea of what is going on.

> The thinking when we did this was that if the fragment is done executing and all we're
doing is keeping a single thread alive that is periodically retrying sending the status report
(we use exponential backoff based on the number of failed reports, so it wouldn't be very
frequent) its pretty cheap and better than having the backend cancel itself if the coordinator
actually is still alive. You make a good point that we could have the fragments get cancelled
if the coordinator is removed from the cluster membership.

I'm going to try and follow up on this.



-- 
To view, visit http://gerrit.cloudera.org:8080/15666
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If9fe8309f80f797d205b756ba58219f595aba4e5
Gerrit-Change-Number: 15666
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <stakiar@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <stakiar@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Apr 2020 21:46:41 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message