impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1
Date Wed, 08 Apr 2020 19:06:06 GMT
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15642 )

Change subject: IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1
......................................................................


Patch Set 6:

I think we can probably live with a 10-15% regression for extreme cases like that, it would
be a bit heroic to try to fix it in sqlparse.


-- 
To view, visit http://gerrit.cloudera.org:8080/15642
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I77a1fd5ae311634a18ee04b8c389d8a3f3a6e001
Gerrit-Change-Number: 15642
Gerrit-PatchSet: 6
Gerrit-Owner: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <stakiar@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Apr 2020 19:06:06 +0000
Gerrit-HasComments: No

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message