impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Use Python from the toolchain for Impala
Date Wed, 08 Apr 2020 18:58:25 GMT
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15624 )

Change subject: Use Python from the toolchain for Impala
......................................................................


Patch Set 11: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/15624/11//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15624/11//COMMIT_MSG@7
PS11, Line 7: Use Python from the toolchain for Impala
I think this is significant enough to deserve a JIRA. I filed IMPALA-9626


http://gerrit.cloudera.org:8080/#/c/15624/11/tests/conftest.py
File tests/conftest.py:

http://gerrit.cloudera.org:8080/#/c/15624/11/tests/conftest.py@620
PS11, Line 620: 
nit: extra blank line



-- 
To view, visit http://gerrit.cloudera.org:8080/15624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7b40cef89cfb3b467b61b2d54a94e708642882b
Gerrit-Change-Number: 15624
Gerrit-PatchSet: 11
Gerrit-Owner: Laszlo Gaal <laszlo.gaal@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <laszlo.gaal@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Apr 2020 18:58:25 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message