impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Laszlo Gaal (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Add CentOS 8.1 support to bootstrap system.sh
Date Wed, 08 Apr 2020 18:51:35 GMT
Hello Zoltan Borok-Nagy, David Knupp, Tim Armstrong, Joe McDonnell, Impala Public Jenkins,


I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15623

to look at the new patch set (#9).

Change subject: Add CentOS 8.1 support to bootstrap_system.sh
......................................................................

Add CentOS 8.1 support to bootstrap_system.sh

CentOS 8.1 is a new major version of the CentOS family.
It is now stable and popular enough to start supporting it for Impala
development.

Prepare a raw CentOS 8.1 system to support Impala development and testing.
This should work on a standalone computer, on a virtual machine,
or inside a Docker container.

Details:
- curl is added to the list of required packages, required by
  IMPALA-9149
- snappy-devel moved to the PowerTools repo, so it needs to be installed
  from there
- CentOS 8 has no default Python version. The bootstrap script installs
  (or configures) Python2 with pip2, then makes them the default via the
  "alternatives" mechanism. The installer is adaptive, it performs only
  the necessary steps, so it works in various environments.
  The installer logic is also shared between bin/bootstrap_system.sh and
  docker/entrypoint.sh
- The toolchain package tag "ec2-centos-8" is added to
  bootstrap_toolchain.py
- For some unknown reason, when the downloaded Maven tarball is extracted
  in a Docker-based test, the "bin" and "boot" directories are created
  with owner-only permissions. The 'impdev' users has no access to the
  maven executable, which then breaks the build.
  This patch forcibly restores the correct permissions on these
  directories; this is a no-op when the extraction happens correctly.
- TOOLCHAIN_ID is bumped to a build that already has CentOS 8 binaries.
- Add Centos8-specific bootstrap code to the Docker-based tests.

Change-Id: I3df5d48eca7a10219264e3604a4f05f072188e6e
---
M bin/bootstrap_system.sh
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M docker/entrypoint.sh
4 files changed, 115 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/15623/9
-- 
To view, visit http://gerrit.cloudera.org:8080/15623
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3df5d48eca7a10219264e3604a4f05f072188e6e
Gerrit-Change-Number: 15623
Gerrit-PatchSet: 9
Gerrit-Owner: Laszlo Gaal <laszlo.gaal@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <laszlo.gaal@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <boroknagyz@cloudera.com>

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message