impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Laszlo Gaal (Code Review)" <>
Subject [Impala-ASF-CR] Use Python from the toolchain for Impala
Date Wed, 08 Apr 2020 18:50:47 GMT
Laszlo Gaal has posted comments on this change. ( )

Change subject: Use Python from the toolchain for Impala

Patch Set 10:

Commit Message:
PS6, Line 17: native
> Nit: native
PS6, Line 20: Python2
            : version from the toolchain
> This is larger question, but would we ever consider having both python3 and
Python3 is already built in the toolchain in addition to Python2 (see,
although I'm not sure how much testing it gets, if any.
File bin/
PS6, Line 34: PYTHONPATH=${PYTHONPATH}:${IMPALA_HOME}/infra/python/env/lib
> Should this be .../infra/python/env/lib ?
File infra/python/
PS6, Line 50: LOG = logging.getLogger(os.path.splitext(os.path.basename(__file__))[0])
            : DEPS_DIR = os.path.join(os.path.dirname(__file__), "deps")
            : ENV_DIR = os.path.join(os.path.
> I think this was for my debugging only, so we can remove it.
PS6, Line 92: def exec_cmd(args, **kwargs):
            :   '''Executes a command and
> Can these lines be removed? I think Tim suggested that we didn't need tmp.p
PS6, Line 209:   if not os.path.exists(python_cmd):
> This feels like a bit of a hack, but I think we can live with it.
File infra/python/

> I think we can remove this, this was just for debugging issues I was having
File tests/common/
PS6, Line 156:     cls.client = None
> I almost feel like this check might better be done via a fixture in conftes

To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7b40cef89cfb3b467b61b2d54a94e708642882b
Gerrit-Change-Number: 15624
Gerrit-PatchSet: 10
Gerrit-Owner: Laszlo Gaal <>
Gerrit-Reviewer: David Knupp <>
Gerrit-Reviewer: Impala Public Jenkins <>
Gerrit-Reviewer: Joe McDonnell <>
Gerrit-Reviewer: Laszlo Gaal <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-Comment-Date: Wed, 08 Apr 2020 18:50:47 +0000
Gerrit-HasComments: Yes

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message