impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aman Sinha (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-9529: Fix multi-tuple predicates not assigned in column masking
Date Wed, 08 Apr 2020 01:46:12 GMT
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/15654 )

Change subject: IMPALA-9529: Fix multi-tuple predicates not assigned in column masking
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15654/3/fe/src/main/java/org/apache/impala/analysis/Analyzer.java
File fe/src/main/java/org/apache/impala/analysis/Analyzer.java:

http://gerrit.cloudera.org:8080/#/c/15654/3/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@1493
PS3, Line 1493:     if (node instanceof JoinNode) {
> I'm afraid that doesn't work since JoinNode.init() is calling this method t
Ok, that makes sense.  Thanks.



-- 
To view, visit http://gerrit.cloudera.org:8080/15654
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I12f1b59733db5a88324bb0c16085f565edc306b3
Gerrit-Change-Number: 15654
Gerrit-PatchSet: 5
Gerrit-Owner: Quanlong Huang <huangquanlong@gmail.com>
Gerrit-Reviewer: Aman Sinha <amsinha@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringhofer@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fangyu.rao@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <huangquanlong@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vihang@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Apr 2020 01:46:12 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message