Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15653
)
Change subject: IMPALA-9602: Fix case-sensitivity for local catalog
......................................................................
Patch Set 3:
(3 comments)
Patch looks good to me. Left a few suggestions below.
http://gerrit.cloudera.org:8080/#/c/15653/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15653/3//COMMIT_MSG@21
PS3, Line 21: start Impala with local catalog enabled
: start-impala-cluster.py
: --catalogd_args="--catalog_topic_mode=minimal"
: --impalad_args="--use_local_catalog=true"
: Create database in lower-case: "CREATE DATABASE db1;"
: Run the following a few times (this errors without the patch):
: impala-shell.sh -q "DROP TABLE IF EXISTS DB1.ddl_test1 PURGE;
: CREATE TABLE DB1.ddl_test1 (val string)
We have a test_local_catalog.py or test_ddl.py in case you want to add this test case.
http://gerrit.cloudera.org:8080/#/c/15653/3/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java
File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java:
http://gerrit.cloudera.org:8080/#/c/15653/3/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@625
PS3, Line 625: DbCacheKey
May be its better to move toLowerCase() call inside DbCacheKey constructor. That way any future
usage of dbName will not need a explicit lower-casing.
http://gerrit.cloudera.org:8080/#/c/15653/3/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@681
PS3, Line 681: TableCacheKey
same as earlier, may be moving to TableCacheKey constructor is better.
--
To view, visit http://gerrit.cloudera.org:8080/15653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f368fa9b50e22ec5057d0bf66c3fd51064d4c26
Gerrit-Change-Number: 15653
Gerrit-PatchSet: 3
Gerrit-Owner: Aman Sinha <amsinha@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vihang@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Apr 2020 18:19:05 +0000
Gerrit-HasComments: Yes
|