impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-9545 Decide cacheline size of aarch64
Date Tue, 07 Apr 2020 15:58:32 GMT
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15555
)

Change subject: IMPALA-9545 Decide cacheline size of aarch64
......................................................................

IMPALA-9545 Decide cacheline size of aarch64

ARM64's L3 cacheline size is different according
 to CPU vendor's architecture. If user defined
 CACHELINESIZE_AARCH64 in impala-config-local.sh,
then we will use that value, if user did not
 define it, then we will get the value from OS,
if fail, then we will use the default value 64.

Change-Id: Id56bfa63e4b6cd957c4997f10de78a5f4111f61f
Reviewed-on: http://gerrit.cloudera.org:8080/15555
Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
---
M CMakeLists.txt
M be/CMakeLists.txt
M be/src/gutil/port.h
M buildall.sh
4 files changed, 32 insertions(+), 0 deletions(-)

Approvals:
  Tim Armstrong: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/15555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id56bfa63e4b6cd957c4997f10de78a5f4111f61f
Gerrit-Change-Number: 15555
Gerrit-PatchSet: 9
Gerrit-Owner: Anonymous Coward <zhaorenhai@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zhaorenhai@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message