impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-9543 Reduce duplicate code in thrift CMakeLists.txt
Date Tue, 07 Apr 2020 11:11:35 GMT
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15527
)

Change subject: IMPALA-9543 Reduce duplicate code in thrift CMakeLists.txt
......................................................................

IMPALA-9543 Reduce duplicate code in thrift CMakeLists.txt

Reduce duplicate code in thrift CMakeLists.txt.
And if in future, we change hive to version 4 or higher.
This can adapt autometically.
Change-Id: Ie55b89bb689375cbb55c22f6d5543a5422b29a82
Reviewed-on: http://gerrit.cloudera.org:8080/15527
Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
---
M common/thrift/CMakeLists.txt
1 file changed, 2 insertions(+), 9 deletions(-)

Approvals:
  Tim Armstrong: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/15527
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie55b89bb689375cbb55c22f6d5543a5422b29a82
Gerrit-Change-Number: 15527
Gerrit-PatchSet: 15
Gerrit-Owner: Anonymous Coward <zhaorenhai@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message