impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Quanlong Huang (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-9529: Fix multi-tuple predicates not assigned in column masking
Date Tue, 07 Apr 2020 07:43:43 GMT
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15654
)

Change subject: IMPALA-9529: Fix multi-tuple predicates not assigned in column masking
......................................................................


Patch Set 4:

(2 comments)

Thanks for your review, Aman!

Addressed Aman's comment: added a new field 'maskedByTuple_' in TupleDescriptor and check
it in JoinNode.init().

http://gerrit.cloudera.org:8080/#/c/15654/3/fe/src/main/java/org/apache/impala/analysis/Analyzer.java
File fe/src/main/java/org/apache/impala/analysis/Analyzer.java:

http://gerrit.cloudera.org:8080/#/c/15654/3/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@1493
PS3, Line 1493:     if (node instanceof JoinNode) {
> For adding the marker I thought you would just need to add a boolean 'isAss
I'm afraid that doesn't work since JoinNode.init() is calling this method to update 'conjuncts_'.
The call path is:

  JoinNode.init() -> PlanNode.assignConjuncts() -> analyzer.getUnassignedConjuncts(PlanNode)

We can only use these codes after 'conjuncts_' is updated.


http://gerrit.cloudera.org:8080/#/c/15654/3/fe/src/main/java/org/apache/impala/planner/JoinNode.java
File fe/src/main/java/org/apache/impala/planner/JoinNode.java:

http://gerrit.cloudera.org:8080/#/c/15654/3/fe/src/main/java/org/apache/impala/planner/JoinNode.java@224
PS3, Line 224:     for (TupleDescriptor tuple : analyzer.materializeSlots(conjuncts_)) {
> Yeah, if you can add a Preconditions check that would be good.
Done. Slightly fixed the comment that masked tuples involved in multi-tuple predicates could
be affected.



-- 
To view, visit http://gerrit.cloudera.org:8080/15654
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I12f1b59733db5a88324bb0c16085f565edc306b3
Gerrit-Change-Number: 15654
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <huangquanlong@gmail.com>
Gerrit-Reviewer: Aman Sinha <amsinha@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringhofer@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fangyu.rao@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <huangquanlong@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vihang@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Apr 2020 07:43:43 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message