impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Quanlong Huang (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-9529: Fix multi-tuple predicates not assigned in column masking
Date Tue, 07 Apr 2020 04:48:05 GMT
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15654
)

Change subject: IMPALA-9529: Fix multi-tuple predicates not assigned in column masking
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/15654/3/fe/src/main/java/org/apache/impala/analysis/Analyzer.java
File fe/src/main/java/org/apache/impala/analysis/Analyzer.java:

http://gerrit.cloudera.org:8080/#/c/15654/3/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@1493
PS3, Line 1493:     if (node instanceof JoinNode) {
> It would be useful to tag the JoinNode with some special marker that it is 
Yeah, but to add this marker, we still need to loop over all the TableRefs of the JoinNode.
Looks like it doesn't optimize a lot. I think we can do this optimization later.


http://gerrit.cloudera.org:8080/#/c/15654/3/fe/src/main/java/org/apache/impala/planner/JoinNode.java
File fe/src/main/java/org/apache/impala/planner/JoinNode.java:

http://gerrit.cloudera.org:8080/#/c/15654/3/fe/src/main/java/org/apache/impala/planner/JoinNode.java@224
PS3, Line 224:     for (TupleDescriptor tuple : analyzer.materializeSlots(conjuncts_)) {
> Would this loop be penalizing joins in the normal case ? i.e if there is no
analyzer.materializeSlots(conjuncts_) only returns the affected tuples. In normal code path
(without nested columns or column masking), the returned set is empty. I think I can add some
Precondition checks for "only tuples of the masked tables could be affected".



-- 
To view, visit http://gerrit.cloudera.org:8080/15654
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I12f1b59733db5a88324bb0c16085f565edc306b3
Gerrit-Change-Number: 15654
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <huangquanlong@gmail.com>
Gerrit-Reviewer: Aman Sinha <amsinha@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringhofer@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fangyu.rao@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <huangquanlong@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vihang@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Apr 2020 04:48:05 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message