impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aman Sinha (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-9602: Fix case-sensitivity for local catalog
Date Tue, 07 Apr 2020 01:47:25 GMT
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15653

to look at the new patch set (#3).

Change subject: IMPALA-9602: Fix case-sensitivity for local catalog
......................................................................

IMPALA-9602: Fix case-sensitivity for local catalog

This patch makes the database and table names lower-case
when doing lookups, insertion and invalidations of database
objects or table objects in the local catalog cache. The
remote catalog already does the right thing by lower-casing
these names, so this patch makes the behavior consistent with
what the remote catalog does.

Testing:
 - Added unit tests for CatalogdMetaProvider by examining
   cache hits and misses when loading and invalidating
   database or tables with upper-case names.
 - Manually tested as follows:
   start Impala with local catalog enabled
    start-impala-cluster.py
     --catalogd_args="--catalog_topic_mode=minimal"
     --impalad_args="--use_local_catalog=true"
   Create database in lower-case: "CREATE DATABASE db1;"
   Run the following a few times (this errors without the patch):
   impala-shell.sh -q "DROP TABLE IF EXISTS DB1.ddl_test1 PURGE;
                  CREATE TABLE DB1.ddl_test1 (val string);"

Change-Id: I3f368fa9b50e22ec5057d0bf66c3fd51064d4c26
---
M fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java
M fe/src/test/java/org/apache/impala/catalog/local/CatalogdMetaProviderTest.java
2 files changed, 65 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/15653/3
-- 
To view, visit http://gerrit.cloudera.org:8080/15653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3f368fa9b50e22ec5057d0bf66c3fd51064d4c26
Gerrit-Change-Number: 15653
Gerrit-PatchSet: 3
Gerrit-Owner: Aman Sinha <amsinha@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenkins@cloudera.com>

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message