impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-9602: Fix case-sensitivity for local catalog
Date Sun, 05 Apr 2020 19:31:06 GMT
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15653
)

Change subject: IMPALA-9602: Fix case-sensitivity for local catalog
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/15653/1/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java
File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java:

http://gerrit.cloudera.org:8080/#/c/15653/1/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@681
PS1, Line 681:     TableCacheKey cacheKey = new TableCacheKey(dbName.toLowerCase(), tableName.toLowerCase());
line too long (94 > 90)


http://gerrit.cloudera.org:8080/#/c/15653/1/fe/src/test/java/org/apache/impala/catalog/local/CatalogdMetaProviderTest.java
File fe/src/test/java/org/apache/impala/catalog/local/CatalogdMetaProviderTest.java:

http://gerrit.cloudera.org:8080/#/c/15653/1/fe/src/test/java/org/apache/impala/catalog/local/CatalogdMetaProviderTest.java@340
PS1, Line 340:   // names as case-insensitive. 
line has trailing whitespace



-- 
To view, visit http://gerrit.cloudera.org:8080/15653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f368fa9b50e22ec5057d0bf66c3fd51064d4c26
Gerrit-Change-Number: 15653
Gerrit-PatchSet: 1
Gerrit-Owner: Aman Sinha <amsinha@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Gerrit-Comment-Date: Sun, 05 Apr 2020 19:31:06 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message