impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Knupp (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Use Python from the toolchain for Impala
Date Thu, 02 Apr 2020 20:48:26 GMT
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15624 )

Change subject: Use Python from the toolchain for Impala
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/15624/6//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15624/6//COMMIT_MSG@17
PS6, Line 17: mative
Nit: native


http://gerrit.cloudera.org:8080/#/c/15624/6//COMMIT_MSG@20
PS6, Line 20: Python2
            : version from the toolchain
This is larger question, but would we ever consider having both python3 and python2 in the
toolchain? The impala-shell will be python3 compatible before the rest of the python code,
e.g. the test harness, is python3 compatible, but it would be good to have both versions on
hand to test changes to shell.



-- 
To view, visit http://gerrit.cloudera.org:8080/15624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7b40cef89cfb3b467b61b2d54a94e708642882b
Gerrit-Change-Number: 15624
Gerrit-PatchSet: 6
Gerrit-Owner: Laszlo Gaal <laszlo.gaal@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <laszlo.gaal@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Comment-Date: Thu, 02 Apr 2020 20:48:26 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message