impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Fix THttpServer to not call the cookie function with an empty cookie
Date Tue, 27 Aug 2019 21:46:32 GMT
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14149
)

Change subject: Fix THttpServer to not call the cookie function with an empty cookie
......................................................................

Fix THttpServer to not call the cookie function with an empty cookie

This patch checks if the value passed in the 'Cookie' header to the
http hs2 server is blank, and if so it ignores it.

The reason to do this is so that a client sending an empty cookie
header isn't counted as a failed cookie attempt, which is incorrect.

Change-Id: I04e96fe97baae474a82fd30f2cd55ccce80570b4
Reviewed-on: http://gerrit.cloudera.org:8080/14149
Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
---
M be/src/transport/THttpServer.cpp
1 file changed, 9 insertions(+), 5 deletions(-)

Approvals:
  Tim Armstrong: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/14149
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I04e96fe97baae474a82fd30f2cd55ccce80570b4
Gerrit-Change-Number: 14149
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Attila Jeges <attilaj@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message