impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Marshall (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-1653: Don't close hiveserver2 session when connection is closed
Date Fri, 10 May 2019 23:22:14 GMT
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/13306
)

Change subject: IMPALA-1653: Don't close hiveserver2 session when connection is closed
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13306/2/tests/hs2/test_hs2.py
File tests/hs2/test_hs2.py:

http://gerrit.cloudera.org:8080/#/c/13306/2/tests/hs2/test_hs2.py@621
PS2, Line 621:     """Tests that an hs2 session reamins valid even after the connection is
dropped."""
> Nit: needs a description
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/13306
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4555cd9b73db5b4dde92cd4fac4f9bfa3664d78
Gerrit-Change-Number: 13306
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <asherman@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tmarshall@cloudera.com>
Gerrit-Comment-Date: Fri, 10 May 2019 23:22:14 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message