From reviews-return-27228-archive-asf-public=cust-asf.ponee.io@impala.apache.org Fri Jan 12 22:29:38 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 3915F180621 for ; Fri, 12 Jan 2018 22:29:38 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 293BF160C33; Fri, 12 Jan 2018 21:29:38 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6E65D160C20 for ; Fri, 12 Jan 2018 22:29:37 +0100 (CET) Received: (qmail 65993 invoked by uid 500); 12 Jan 2018 21:29:36 -0000 Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.apache.org Received: (qmail 65981 invoked by uid 99); 12 Jan 2018 21:29:36 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Jan 2018 21:29:36 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id ED50DC2C48 for ; Fri, 12 Jan 2018 21:29:35 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id ksb_kKkSi4Wt for ; Fri, 12 Jan 2018 21:29:35 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 657705F24C for ; Fri, 12 Jan 2018 21:29:34 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id w0CLTWP2031563; Fri, 12 Jan 2018 21:29:32 GMT Message-Id: <201801122129.w0CLTWP2031563@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 3 Date: Fri, 12 Jan 2018 21:29:32 +0000 From: "Taras Bobrovytsky (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-6388=3A_Fix_the_Union_node_number_of_hosts_estimation=0A?= X-Gerrit-Change-Id: I51e1ecca8dbc84b2b5a72708667b2799d00279f0 X-Gerrit-Change-Number: 9017 X-Gerrit-ChangeURL: X-Gerrit-Commit: 92ceaaef319214139a405b95f927aa06c02af917 In-Reply-To: References: Reply-To: tbobrovytsky@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="otUqY758i1I="; charset=UTF-8 --otUqY758i1I= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Taras Bobrovytsky has uploaded a new patch set (#3)=2E ( http://gerrit=2Ecl= oudera=2Eorg:8080/9017 ) Change subject: IMPALA-6388: Fix the Union node n= umber of hosts estimation =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E IMPALA-6388: Fix the Union node number of hosts estimation B= efore this patch, we would estimate the number of hosts for the union node = by looking only at the first union operand=2E This is obviously incorrect a= nd lead us to underestimate the value=2E We fix the problem by setting the= estimate to be the maximum of its children=2E Testing: - Added a planner = test that reproduces the issue Change-Id: I51e1ecca8dbc84b2b5a72708667b279= 9d00279f0 --- M fe/src/main/java/org/apache/impala/planner/UnionNode=2Ejava= M testdata/workloads/functional-planner/queries/PlannerTest/union=2Etest 2= files changed, 89 insertions(+), 0 deletions(-) git pull ssh://gerrit= =2Ecloudera=2Eorg:29418/Impala-ASF refs/changes/17/9017/3 -- To view, visi= t http://gerrit=2Ecloudera=2Eorg:8080/9017 To unsubscribe, visit http://ger= rit=2Ecloudera=2Eorg:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branc= h: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I51e1ecca8dbc84= b2b5a72708667b2799d00279f0 Gerrit-Change-Number: 9017 Gerrit-PatchSet: 3 Ge= rrit-Owner: Taras Bobrovytsky Gerrit-Reviewer= : Alex Behm Gerrit-Reviewer: Taras Bobrovytsky= --otUqY758i1I=--