From reviews-return-27162-archive-asf-public=cust-asf.ponee.io@impala.apache.org Fri Jan 12 12:18:58 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id B0E6B180621 for ; Fri, 12 Jan 2018 12:18:58 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 9E543160C33; Fri, 12 Jan 2018 11:18:58 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DF3D9160C30 for ; Fri, 12 Jan 2018 12:18:57 +0100 (CET) Received: (qmail 25914 invoked by uid 500); 12 Jan 2018 11:18:57 -0000 Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.apache.org Received: (qmail 25903 invoked by uid 99); 12 Jan 2018 11:18:56 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Jan 2018 11:18:56 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 6A0BE1A08D3 for ; Fri, 12 Jan 2018 11:18:56 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id MvNe0xhdaLlT for ; Fri, 12 Jan 2018 11:18:55 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 8342D5F297 for ; Fri, 12 Jan 2018 11:18:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id w0CBIp2C017077; Fri, 12 Jan 2018 11:18:51 GMT Message-Id: <201801121118.w0CBIp2C017077@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 3 Date: Fri, 12 Jan 2018 11:18:49 +0000 From: "Gabor Kaszab (Code Review)" To: John Russell , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Tim Armstrong X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-2181=3A_=5BDOCS=5D_Document_changes_to_SET_output=0A?= X-Gerrit-Change-Id: Iade7cb326715ebbb8518230d518d05601d615f61 X-Gerrit-Change-Number: 8865 X-Gerrit-ChangeURL: X-Gerrit-Commit: 19a0e31fc305e59d7f351194d90d134d6e33944c In-Reply-To: References: X-Gerrit-Comment-Date: Fri, 12 Jan 2018 11:18:49 +0000 Reply-To: gaborkaszab@cloudera.com, jrussell@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com, tarmstrong@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="b2KLsRxEoqY="; charset=UTF-8 --b2KLsRxEoqY= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Gabor Kaszab has posted comments on this change=2E ( http://gerrit=2Ecloude= ra=2Eorg:8080/8865 ) Change subject: IMPALA-2181: [DOCS] Document changes = to SET output =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= Patch Set 3: Code-Review+1 (1 comment) Thanks John for the changes! Lo= oks good to me=2E http://gerrit=2Ecloudera=2Eorg:8080/#/c/8865/3/docs/topi= cs/impala_set=2Exml File docs/topics/impala_set=2Exml: http://gerrit=2Eclo= udera=2Eorg:8080/#/c/8865/3/docs/topics/impala_set=2Exml@54 PS3, Line 54: = In and higher, the output of th= e SET nit: I'm not sure how you treat trailing spa= ces in docs=2E Would you mind dropping them here? -- To view, visit htt= p://gerrit=2Ecloudera=2Eorg:8080/8865 To unsubscribe, visit http://gerrit= =2Ecloudera=2Eorg:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: = master Gerrit-MessageType: comment Gerrit-Change-Id: Iade7cb326715ebbb85182= 30d518d05601d615f61 Gerrit-Change-Number: 8865 Gerrit-PatchSet: 3 Gerrit-Ow= ner: John Russell Gerrit-Reviewer: Gabor Kaszab <= gaborkaszab@cloudera=2Ecom> Gerrit-Reviewer: John Russell Gerrit-Reviewer: Tim Armstrong Gerrit-= Comment-Date: Fri, 12 Jan 2018 11:18:49 +0000 Gerrit-HasComments: Yes --b2KLsRxEoqY=--