From reviews-return-27073-archive-asf-public=cust-asf.ponee.io@impala.apache.org Thu Jan 11 20:12:52 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 10F0C180656 for ; Thu, 11 Jan 2018 20:12:52 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 00A11160C23; Thu, 11 Jan 2018 19:12:52 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 45F6B160C13 for ; Thu, 11 Jan 2018 20:12:51 +0100 (CET) Received: (qmail 94238 invoked by uid 500); 11 Jan 2018 19:12:50 -0000 Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.apache.org Received: (qmail 94216 invoked by uid 99); 11 Jan 2018 19:12:50 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Jan 2018 19:12:50 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id CA3D7C03E9 for ; Thu, 11 Jan 2018 19:12:49 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id dapc3dNvBQFM for ; Thu, 11 Jan 2018 19:12:49 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id D08295F3CD for ; Thu, 11 Jan 2018 19:12:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id w0BJCl4R022779; Thu, 11 Jan 2018 19:12:47 GMT Message-Id: <201801111912.w0BJCl4R022779@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 2 Date: Thu, 11 Jan 2018 19:12:47 +0000 From: "Thomas Tauber-Marshall (Code Review)" To: John Russell , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Todd Lipcon X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4252=3A_=5BDOCS=5D_Document_min/max_filters_for_Kudu_tables=0A?= X-Gerrit-Change-Id: I15d8c952ab5b90e89fdd57640dfb4da882f7ecb2 X-Gerrit-Change-Number: 8986 X-Gerrit-ChangeURL: X-Gerrit-Commit: 2046f9d0cfeab2cc9e19d4e48f706165c86a6bef In-Reply-To: References: X-Gerrit-Comment-Date: Thu, 11 Jan 2018 19:12:47 +0000 Reply-To: tmarshall@cloudera.com, jrussell@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com, todd@apache.org, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="uncwpXjTy9M="; charset=UTF-8 --uncwpXjTy9M= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Thomas Tauber-Marshall has posted comments on this change=2E ( http://gerri= t=2Ecloudera=2Eorg:8080/8986 ) Change subject: IMPALA-4252: [DOCS] Documen= t min/max filters for Kudu tables =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E Patch Set 2: (3 comments) http://gerrit=2Eclouder= a=2Eorg:8080/#/c/8986/1/docs/topics/impala_runtime_filtering=2Exml File doc= s/topics/impala_runtime_filtering=2Exml: http://gerrit=2Ecloudera=2Eorg:80= 80/#/c/8986/1/docs/topics/impala_runtime_filtering=2Exml@173 PS1, Line 173:= : For HD > Done=2E Because this paragraph is followe= d by info that's only relevant for B Actually, the partitioned/broadcast an= d local/global discussion applies to min-max filters as well=2E I should a= lso add that the long term plan is to have all filter types supported by al= l scan types, so no need to separate out min-max as being a really specific= ally Kudu thing (though of course it only applies to Kudu at the moment)=2E= http://gerrit=2Ecloudera=2Eorg:8080/#/c/8986/2/docs/topics/impala_runtim= e_filtering=2Exml File docs/topics/impala_runtime_filtering=2Exml: http://= gerrit=2Ecloudera=2Eorg:8080/#/c/8986/2/docs/topics/impala_runtime_filterin= g=2Exml@181 PS2, Line 181: a complete list of relevant values This is the o= nly part I see that doesn't make sense for min-max filters, as they're not = a 'list of values', but then a bloom filter isn't a 'list of values' either= =2E Maybe rephrase it something like "A broadcast filter reflects the comp= lete set of relevant values and can be immediately evaluated=2E=2E=2E" and = "A partitioned filter reflects only the values processed by one host=2E=2E= =2E" or perhaps "contains" instead of reflects http://gerrit=2Ecloudera= =2Eorg:8080/#/c/8986/2/docs/topics/impala_runtime_filtering=2Exml@203 PS2, = Line 203: These filters are used by Kudu to scan a range of values = : for join columns when identifying matching rows within a joi= n query=2E I find this sentence confusing, as Kudu isn't identifying the ma= tching rows (Kudu doesn't even know we're doing a join, its just scanning v= alues for us) Maybe say something like "These filters are passed to Kudu t= o reduce the number of rows returnrf to Impala when scanning the probe side= of the join" -- To view, visit http://gerrit=2Ecloudera=2Eorg:8080/898= 6 To unsubscribe, visit http://gerrit=2Ecloudera=2Eorg:8080/settings Gerri= t-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Ger= rit-Change-Id: I15d8c952ab5b90e89fdd57640dfb4da882f7ecb2 Gerrit-Change-Numb= er: 8986 Gerrit-PatchSet: 2 Gerrit-Owner: John Russell Gerrit-Reviewer: John Russell Gerrit-Revi= ewer: Thomas Tauber-Marshall Gerrit-Reviewer: To= dd Lipcon Gerrit-Comment-Date: Thu, 11 Jan 2018 19:12:4= 7 +0000 Gerrit-HasComments: Yes --uncwpXjTy9M=--