From reviews-return-26929-archive-asf-public=cust-asf.ponee.io@impala.apache.org Wed Jan 10 06:42:34 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 56E6418062E for ; Wed, 10 Jan 2018 06:42:34 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 46EA0160C3F; Wed, 10 Jan 2018 05:42:34 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8F63C160C17 for ; Wed, 10 Jan 2018 06:42:33 +0100 (CET) Received: (qmail 58329 invoked by uid 500); 10 Jan 2018 05:42:32 -0000 Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.apache.org Received: (qmail 58314 invoked by uid 99); 10 Jan 2018 05:42:32 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Jan 2018 05:42:32 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 127E41805C8 for ; Wed, 10 Jan 2018 05:42:32 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id EI0JSja81C0G for ; Wed, 10 Jan 2018 05:42:28 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 6A0AE5FB69 for ; Wed, 10 Jan 2018 05:42:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id w0A5gQiL012027; Wed, 10 Jan 2018 05:42:26 GMT Message-Id: <201801100542.w0A5gQiL012027@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 2 Date: Wed, 10 Jan 2018 05:42:25 +0000 From: "John Russell (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Greg Rahn , Vuk Ercegovac X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-1767=3A_=5BDOCS=5D_Document_new_Boolean_operators=0A?= X-Gerrit-Change-Id: Iefebf210418ec2d47b154bd37166b76720f085bb X-Gerrit-Change-Number: 8942 X-Gerrit-ChangeURL: X-Gerrit-Commit: d3165a6be7db1f1926a186a826d86e344c5a907b In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 10 Jan 2018 05:42:25 +0000 Reply-To: jrussell@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com, reviews@impala.incubator.apache.org, grahn@cloudera.com, vercegovac@cloudera.com MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="XRt+KISn95s="; charset=UTF-8 --XRt+KISn95s= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable John Russell has posted comments on this change=2E ( http://gerrit=2Ecloude= ra=2Eorg:8080/8942 ) Change subject: IMPALA-1767: [DOCS] Document new Bool= ean operators =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= Patch Set 2: (6 comments) http://gerrit=2Ecloudera=2Eorg:8080/#/c/8942= /2/docs/shared/impala_common=2Exml File docs/shared/impala_common=2Exml: h= ttp://gerrit=2Ecloudera=2Eorg:8080/#/c/8942/2/docs/shared/impala_common=2Ex= ml@779 PS2, Line 779: IS [NOT] FALSE as equivalent= s for the functions > "builtin functions" instead of "functions" to match t= he blurb in the detail Done http://gerrit=2Ecloudera=2Eorg:8080/#/c/8942/= 2/docs/topics/impala_operators=2Exml File docs/topics/impala_operators=2Exm= l: http://gerrit=2Ecloudera=2Eorg:8080/#/c/8942/2/docs/topics/impala_opera= tors=2Exml@1251 PS2, Line 1251: lets > nit: let Done http://gerrit=2Eclou= dera=2Eorg:8080/#/c/8942/2/docs/topics/impala_operators=2Exml@1320 PS2, Lin= e 1320: lets > nit: let Done http://gerrit=2Ecloudera=2Eorg:8080/#/c/8942= /2/docs/topics/impala_operators=2Exml@1327 PS2, Line 1327: These operators = are equivalent to the built-in conditional functions > sync this blurb with= the one in the index (see comment there)=2E Done=2E I'll reuse the wording= verbatim with a conref=3D attribute=2E http://gerrit=2Ecloudera=2Eorg:80= 80/#/c/8942/2/docs/topics/impala_operators=2Exml@1337 PS2, Line 1337: query= error > must be same error as for "IS [NOT] NULL" for complex types? perha= ps its le Done http://gerrit=2Ecloudera=2Eorg:8080/#/c/8942/2/docs/topics= /impala_operators=2Exml@1345 PS2, Line 1345: select assertion, b, b is true= , b is false, b is unknown : from boolean_test; > just for = my own info, but why is this lower-case whereas sql inlined in tex I usuall= y save the strict uppercase-keyword style for the detailed syntax blocks=2E= Especially for built-in functions, I use mostly lowercase to be modern-loo= king like C code=2E -- To view, visit http://gerrit=2Ecloudera=2Eorg:80= 80/8942 To unsubscribe, visit http://gerrit=2Ecloudera=2Eorg:8080/settings = Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comme= nt Gerrit-Change-Id: Iefebf210418ec2d47b154bd37166b76720f085bb Gerrit-Chang= e-Number: 8942 Gerrit-PatchSet: 2 Gerrit-Owner: John Russell Gerrit-Reviewer: Greg Rahn Gerrit-Review= er: John Russell Gerrit-Reviewer: Vuk Ercegovac <= vercegovac@cloudera=2Ecom> Gerrit-Comment-Date: Wed, 10 Jan 2018 05:42:25 += 0000 Gerrit-HasComments: Yes --XRt+KISn95s=--