From reviews-return-26895-archive-asf-public=cust-asf.ponee.io@impala.apache.org Wed Jan 10 00:58:08 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 9D623180718 for ; Wed, 10 Jan 2018 00:58:08 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 8BF09160C17; Tue, 9 Jan 2018 23:58:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D0D5F160C3F for ; Wed, 10 Jan 2018 00:58:07 +0100 (CET) Received: (qmail 69304 invoked by uid 500); 9 Jan 2018 23:58:07 -0000 Mailing-List: contact reviews-help@impala.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.apache.org Received: (qmail 69290 invoked by uid 99); 9 Jan 2018 23:58:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Jan 2018 23:58:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 60921180878 for ; Tue, 9 Jan 2018 23:58:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 5qjsTPJNNS9c for ; Tue, 9 Jan 2018 23:58:03 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 80AC95F24F for ; Tue, 9 Jan 2018 23:58:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id w09Nw2KZ031731; Tue, 9 Jan 2018 23:58:02 GMT Message-Id: <201801092358.w09Nw2KZ031731@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 6 Date: Tue, 9 Jan 2018 23:58:02 +0000 From: "Vuk Ercegovac (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Lars Volker , Alex Behm , Tim Armstrong X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4993=3A_extend_dictionary_filtering_to_collections=0A?= X-Gerrit-Change-Id: If3a2abcfc3d0f7d18756816659fed77ce12668dd X-Gerrit-Change-Number: 8775 X-Gerrit-ChangeURL: X-Gerrit-Commit: 14fe31df405324d6add3941731cefffd2a2d6bfb In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 9 Jan 2018 23:58:02 +0000 Reply-To: vercegovac@cloudera.com, impala-cr@cloudera.com, lv@cloudera.com, marcelk@gmail.com, tarmstrong@cloudera.com, alex.behm@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="LQCebAUeDfM="; charset=UTF-8 --LQCebAUeDfM= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Vuk Ercegovac has posted comments on this change=2E ( http://gerrit=2Ecloud= era=2Eorg:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filte= ring to collections =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E Patch Set 6: (5 comments) http://gerrit=2Ecloudera=2Eorg:8080/#/= c/8775/6/be/src/exec/hdfs-parquet-scanner=2Eh File be/src/exec/hdfs-parquet= -scanner=2Eh: http://gerrit=2Ecloudera=2Eorg:8080/#/c/8775/6/be/src/exec/h= dfs-parquet-scanner=2Eh@462 PS6, Line 462: std::unordered_map> > It would make more sense at t= his point to use a MemPool instead of a prolif Replaced with MemPool=2E It= was unclear to me whether to use MemPool or ScopedBuffer for this case (I = didn't see anything in ScopedBuffer to point me in this direction)=2E Let m= e know if you'd like: 1) a blurb in ScopedBuffer that refers to MemPool for= the right use-cases 2) min_max_tuple_buffer also replaced to use MemPool= =2E http://gerrit=2Ecloudera=2Eorg:8080/#/c/8775/6/be/src/exec/hdfs-parqu= et-scanner=2Eh@649 PS6, Line 649: /// Gets the TupleDescriptor of slot_de= sc=2E > Mention that 'slot_desc' can belong to the top-level tuple or a tup= le neste Done http://gerrit=2Ecloudera=2Eorg:8080/#/c/8775/6/be/src/exec/= hdfs-parquet-scanner=2Ecc File be/src/exec/hdfs-parquet-scanner=2Ecc: http= ://gerrit=2Ecloudera=2Eorg:8080/#/c/8775/6/be/src/exec/hdfs-parquet-scanner= =2Ecc@771 PS6, Line 771: if (!col_reader->IsCollectionReader()) { > nit: = I think this would be easier to follow if we reversed the branches and Done= http://gerrit=2Ecloudera=2Eorg:8080/#/c/8775/6/be/src/exec/hdfs-parquet-= scanner=2Ecc@815 PS6, Line 815: for (auto* col_reader : column_readers_) = { > nit: could fit on one line now Done http://gerrit=2Ecloudera=2Eorg:80= 80/#/c/8775/6/be/src/exec/hdfs-parquet-scanner=2Ecc@1657 PS6, Line 1657: = if (column_readers=2Eempty()) return Status::OK(); > Is the early exit nece= ssary for correctness? Might be worth mentioning if i removed=2E -- To = view, visit http://gerrit=2Ecloudera=2Eorg:8080/8775 To unsubscribe, visit = http://gerrit=2Ecloudera=2Eorg:8080/settings Gerrit-Project: Impala-ASF Ge= rrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If3a2abcf= c3d0f7d18756816659fed77ce12668dd Gerrit-Change-Number: 8775 Gerrit-PatchSet= : 6 Gerrit-Owner: Vuk Ercegovac Gerrit-Reviewer= : Alex Behm Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong G= errit-Reviewer: Vuk Ercegovac Gerrit-Comment-Da= te: Tue, 09 Jan 2018 23:58:02 +0000 Gerrit-HasComments: Yes --LQCebAUeDfM=--